[GitHub] HuangZhenQiu commented on issue #7356: [FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers

[GitBox <gi...@apache.org>]

HuangZhenQiu commented on issue #7356: [FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#issuecomment-459833947
 
 
   @tillrohrmann @suez1224 
   Thanks for reviewing the PR. According to your suggestions. I changed as
   1) As the feature is generic for both Yarn and Mesos, add only the maximum failure rate config option in resource manager config. 
   2) Put failure rate related logic into the TimestampBasedFailureRater which implements the FailureRater interface. As I don't want to mix two changes with different purpose in the same PR, we can make other code FailureRateRestartStrategy use it in another small PR.
   3) For the failure rate test for RM, I tried to do in ResourceManagerTest. I found it is hard to mimic the behavior of registerSlotRequest without mocking lots components. And I also have to setup Test RM exactly like what YarnResourceManagerTest is doing. Thus, I still put the test cases separately in YarnResourceManagerTest and MesosResourceManagerTest.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services