You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/03/04 23:09:55 UTC
[kudu-CR] WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12655
Change subject: WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
......................................................................
WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
This patch specifies the environment variable MACOSX_DEPLOYMENT_TARGET
when building the binary test jar for macOS in order to specify the
macOS SDK version to build against.
The environment variable is set before calling
thirdparty/build-if-necessary.sh, however there is no logic to detect
whether a previous thirdparty build happened without the environment
variable set.
Maybe this flag should be incorporated into the macOS Kudu build at a
more fundamental level, rather than being tacked onto the binary jar
build script, or perhaps this script should run git clean -xdf
thirdparty or something similar when running on macOS to ensure that we
ship thirdparty shared objects targeted for the intended platform.
Marked as WIP because this patch needs to be tested on a Mac.
Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
1 file changed, 14 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/12655/1
--
To view, visit http://gerrit.cloudera.org:8080/12655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
Gerrit-Change-Number: 12655
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2724: binary jar build on OSX should specify target macOS version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/12655 )
Change subject: KUDU-2724: binary jar build on OSX should specify target macOS version
......................................................................
KUDU-2724: binary jar build on OSX should specify target macOS version
This patch specifies the environment variable MACOSX_DEPLOYMENT_TARGET
when building the binary test jar for macOS in order to specify the
macOS SDK version to build against.
The environment variable is set before calling
thirdparty/build-if-necessary.sh, however there is no logic to detect
whether a previous thirdparty build happened without the environment
variable set.
Maybe this flag should be incorporated into the macOS Kudu build at a
more fundamental level, rather than being tacked onto the binary jar
build script, or perhaps this script should run git clean -xdf
thirdparty or something similar when running on macOS to ensure that we
ship thirdparty shared objects targeted for the intended platform.
NOTE: trying to build third-party for MACOSX_DEPLOYMENT_TARGET=10.12
on macOS 10.13 with development environment installed by Xcode 10,
the following error surfaced:
thirdparty/src/gperftools-2.6.90/src/tests/tcmalloc_unittest.cc:1382:5: error:
aligned deallocation function of type 'void (void *, std::size_t, std::align_val_t) throw()'
is only available on macOS 10.13 or newer [-Waligned-allocation-unavailable]
Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
1 file changed, 14 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/12655/2
--
To view, visit http://gerrit.cloudera.org:8080/12655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
Gerrit-Change-Number: 12655
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12655 )
Change subject: WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
......................................................................
Patch Set 1:
> (1 comment)
It turns out this works somehow in the sense that MACOSX_DEPLOYMENT_TARGET environment variable affects the build of various components in thirdparty. For example, on macOS 10.13.6 thirdparty was building without an issue without setting this variable, but as soon as I set did 'export MACOSX_DEPLOYMENT_TARGET=10.12', an attempt to build thirdparty failed in gperftools with the following error message:
/Users/aserbin/Projects/mini-cluster/kudu/thirdparty/src/gperftools-2.6.90/src/tests/tcmalloc_unittest.cc:1382:5: error:
aligned deallocation function of type 'void (void *, std::size_t, std::align_val_t) throw()'
is only available on macOS 10.13 or newer [-Waligned-allocation-unavailable]
--
To view, visit http://gerrit.cloudera.org:8080/12655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
Gerrit-Change-Number: 12655
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Nov 2019 00:09:54 +0000
Gerrit-HasComments: No
[kudu-CR] WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12655 )
Change subject: WIP: KUDU-2724: Binary jar build on OSX should specify target macOS version
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12655/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12655/1//COMMIT_MSG@24
PS1, Line 24: Marked as WIP because this patch needs to be tested on a Mac.
Yeah I'd be curious to know whether this works universally. For example, does the clang we build in the thirdparty tree respect it?
--
To view, visit http://gerrit.cloudera.org:8080/12655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib06fec3031e247498b4eefac672c7204a4b3ed61
Gerrit-Change-Number: 12655
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Mar 2019 23:48:45 +0000
Gerrit-HasComments: Yes