[GitHub] [netbeans] JaroslavTulach commented on a diff in pull request #4134: Removing isEventDispatchThread - it causes problems in headless env

[GitBox <gi...@apache.org>]

JaroslavTulach commented on code in PR #4134:
URL: https://github.com/apache/netbeans/pull/4134#discussion_r878629654


##########
platform/sampler/src/org/netbeans/modules/sampler/Sampler.java:
##########
@@ -227,7 +226,6 @@ private synchronized void stopSampling(boolean cancel, DataOutputStream dos) {
             if (cancel || samples < 1) {
                 return;
             }
-            if (SwingUtilities.isEventDispatchThread()) throw new IllegalStateException("sampling cannot be stopped from EDT");  //NOI18N

Review Comment:
   Since https://github.com/apache/netbeans/pull/4052 the `InternalSampler`constructor shall throw `LinkageError` and rather `StandaloneSampler` shall be used in a non-NetBeans environment. `InternalSampler` is intended only for usage in NetBeans/Swing application.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists