You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/04/05 14:30:22 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #4088: SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

zjffdu opened a new pull request #4088:
URL: https://github.com/apache/zeppelin/pull/4088


   ### What is this PR for?
   
   The root cause is that we didn't get SPARK_HOME from env first when detecting scala version. 
   
   ### What type of PR is it?
   [Bug Fix ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5310
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4088: [ZEPPELIN-5310] SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4088:
URL: https://github.com/apache/zeppelin/pull/4088#issuecomment-823132762


   Will merge if no more comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4088: [ZEPPELIN-5310] SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4088:
URL: https://github.com/apache/zeppelin/pull/4088#issuecomment-814578428


   No problem  @cuspymd Thanks for your time on the code review. Very appreciated !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] cuspymd commented on pull request #4088: [ZEPPELIN-5310] SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

Posted by GitBox <gi...@apache.org>.
cuspymd commented on pull request #4088:
URL: https://github.com/apache/zeppelin/pull/4088#issuecomment-814575595


   > 
   > 
   > @cuspymd Could you point where it inconsistent ? Any place we take environment variable first ?
   
   Oh, I'm not saying because there is an error in the code. You don't need to care about it, because I don't have a good understanding of the code yet, so it may feel that way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4088: [ZEPPELIN-5310] SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4088:
URL: https://github.com/apache/zeppelin/pull/4088


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4088: SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4088:
URL: https://github.com/apache/zeppelin/pull/4088#issuecomment-814566829


   @cuspymd Could you point where it inconsistent ? Any place we take environment variable first ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org