You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/17 16:07:51 UTC

[GitHub] [ignite] alex-plekhanov commented on a change in pull request #8431: IGNITE-13633 Fix ServiceDescriptor.serviceClass failure in case of de…

alex-plekhanov commented on a change in pull request #8431:
URL: https://github.com/apache/ignite/pull/8431#discussion_r525284068



##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/service/ServiceHotRedeploymentViaDeploymentSpiTest.java
##########
@@ -61,12 +66,6 @@
         return cfg;
     }
 
-    /** */
-    @BeforeClass

Review comment:
       New test added to this class `testServiceDeploymentViaDeploymentSpi` which also relevant to legacy implementation, so I've moved this check to `serviceHotRedeploymentTest` to skip legacy implementation only for `testServiceHotRedeploymentNode` and `testServiceHotRedeploymentThinClient`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org