[GitHub] [tvm] tkonolige commented on a change in pull request #9003: [microTVM][AutoTVM] Fix autotvm bug and tests

[GitBox <gi...@apache.org>]

tkonolige commented on a change in pull request #9003:
URL: https://github.com/apache/tvm/pull/9003#discussion_r708430753



##########
File path: tutorials/micro/micro_autotune.py
##########
@@ -162,7 +162,7 @@
         n_trial=num_trials,
         measure_option=measure_option,
         callbacks=[
-            tvm.autotvm.callback.log_to_file("microtvm_autotune.log"),
+            tvm.autotvm.callback.log_to_file("microtvm_autotune.log.txt"),

Review comment:
       Why the double extension here?

##########
File path: tutorials/micro/micro_autotune.py
##########
@@ -125,7 +125,7 @@
     do_fork=True,
     build_func=tvm.micro.autotvm_build_func,
 )
-runner = tvm.autotvm.LocalRunner(number=1, repeat=1, timeout=0, module_loader=module_loader)
+runner = tvm.autotvm.LocalRunner(number=1, repeat=1, module_loader=module_loader)

Review comment:
       Maybe set `timeout=100` to be consistent here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org