[GitHub] [nifi] markap14 commented on pull request #5105: NIFI-8635: Add Status Message natively to HandleHTTPResponse

[GitBox <gi...@apache.org>]

markap14 commented on pull request #5105:
URL: https://github.com/apache/nifi/pull/5105#issuecomment-857135324


   Thanks for the improvement @naddym ! I think it makes a lot of sense to add in a Status Message property. Setting the flowfile content is often what we want for a "200 OK" type of response but this makes a lot of sense for other scenarios. The only thing that I'm not sure about is the idea of having this processor update the FlowFile content. I think it makes more sense to send back the use-configured response but not change the FlowFile. I can definitely see cases where we will want to receive an HTTP message, do something with it, then send back a response, and afterwards continue with the FlowFile to do something else. And in the case that we don't want to do anything and want to terminate the flow after HandleHttpResponse, there's no benefit to the overhead of updating FlowFile content.
   
   So it seems to me that we should instead not have the processor update the FlowFile's content at all. But perhaps you have a different viewpoint that I'm missing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org