You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/08 08:01:55 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #12939: support project subquery, in subquery and between subquery convert
strongduanmu opened a new pull request #12939:
URL: https://github.com/apache/shardingsphere/pull/12939
Fixes #12905.
Changes proposed in this pull request:
- support project subquery, in subquery and between subquery convert
- add test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #12939: support project subquery, in subquery and between subquery convert
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #12939:
URL: https://github.com/apache/shardingsphere/pull/12939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #12939: support project subquery, in subquery and between subquery convert
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #12939:
URL: https://github.com/apache/shardingsphere/pull/12939#discussion_r724801433
##########
File path: shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/converter/segment/expression/ExpressionConverter.java
##########
@@ -57,6 +63,12 @@
return new ColumnConverter().convert((ColumnSegment) segment);
} else if (segment instanceof ExistsSubqueryExpression) {
return new ExistsSubqueryExpressionConverter().convert((ExistsSubqueryExpression) segment);
Review comment:
> guard clauses ?
Yes, guard clauses provide better readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #12939: support project subquery, in subquery and between subquery convert
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #12939:
URL: https://github.com/apache/shardingsphere/pull/12939#discussion_r724790669
##########
File path: shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/converter/segment/expression/ExpressionConverter.java
##########
@@ -57,6 +63,12 @@
return new ColumnConverter().convert((ColumnSegment) segment);
} else if (segment instanceof ExistsSubqueryExpression) {
return new ExistsSubqueryExpressionConverter().convert((ExistsSubqueryExpression) segment);
Review comment:
guard clauses ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #12939: support project subquery, in subquery and between subquery convert
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #12939:
URL: https://github.com/apache/shardingsphere/pull/12939#issuecomment-938561506
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12939?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#12939](https://codecov.io/gh/apache/shardingsphere/pull/12939?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9f1003) into [master](https://codecov.io/gh/apache/shardingsphere/commit/27dcc3789591b8d7c851f319e0f31b6ee78fdf90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27dcc37) will **increase** coverage by `0.03%`.
> The diff coverage is `63.93%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/12939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #12939 +/- ##
============================================
+ Coverage 63.31% 63.34% +0.03%
- Complexity 1356 1362 +6
============================================
Files 2480 2497 +17
Lines 37339 37488 +149
Branches 6429 6440 +11
============================================
+ Hits 23640 23746 +106
- Misses 11839 11873 +34
- Partials 1860 1869 +9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...gment/expression/impl/ListExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vaW1wbC9MaXN0RXhwcmVzc2lvbkNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...t/projection/impl/SubqueryProjectionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L3Byb2plY3Rpb24vaW1wbC9TdWJxdWVyeVByb2plY3Rpb25Db252ZXJ0ZXIuamF2YQ==) | `22.22% <22.22%> (ø)` | |
| [...t/expression/impl/SubqueryExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vaW1wbC9TdWJxdWVyeUV4cHJlc3Npb25Db252ZXJ0ZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | |
| [...segment/expression/impl/InExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vaW1wbC9JbkV4cHJlc3Npb25Db252ZXJ0ZXIuamF2YQ==) | `66.66% <66.66%> (ø)` | |
| [...nt/expression/impl/BetweenExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vaW1wbC9CZXR3ZWVuRXhwcmVzc2lvbkNvbnZlcnRlci5qYXZh) | `70.00% <70.00%> (ø)` | |
| [...erter/segment/projection/ProjectionsConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L3Byb2plY3Rpb24vUHJvamVjdGlvbnNDb252ZXJ0ZXIuamF2YQ==) | `88.23% <75.00%> (+3.61%)` | :arrow_up: |
| [...verter/segment/expression/ExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vRXhwcmVzc2lvbkNvbnZlcnRlci5qYXZh) | `72.72% <83.33%> (+10.22%)` | :arrow_up: |
| [...rojection/impl/AggregationProjectionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L3Byb2plY3Rpb24vaW1wbC9BZ2dyZWdhdGlvblByb2plY3Rpb25Db252ZXJ0ZXIuamF2YQ==) | `86.66% <86.66%> (ø)` | |
| [...ession/impl/ExistsSubqueryExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vaW1wbC9FeGlzdHNTdWJxdWVyeUV4cHJlc3Npb25Db252ZXJ0ZXIuamF2YQ==) | `60.00% <100.00%> (ø)` | |
| [...inder/statement/dal/ShowIndexStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RhbC9TaG93SW5kZXhTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `42.85% <0.00%> (-32.15%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/shardingsphere/pull/12939/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12939?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12939?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27dcc37...a9f1003](https://codecov.io/gh/apache/shardingsphere/pull/12939?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org