[GitHub] [iceberg] ggershinsky edited a comment on pull request #3470: API: KMS client interface

[GitBox <gi...@apache.org>]

ggershinsky edited a comment on pull request #3470:
URL: https://github.com/apache/iceberg/pull/3470#issuecomment-1028715893


   > The only real concern I have is that the test class implementations are here but we don't make sure they work. That's probably fine since the actual usage of this interface will exercise those apis? If that's coming up then +1 from me
   
   Yep, these implementations are placed in the test module; they'll serve as a util for a unitest that encrypts/decrypts a table using these test kms classes. This unitest is coming up in the 5th PR in this series, where we connect all parts to enable table encryption.
   Though, I can add a unitest just for these tester kms classes, should be easy - but I wonder if there is a precedent / need in Iceberg to test classes that reside in a test module (not in a main module), and are built for supporting other unitests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org