You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Francesco Mari (JIRA)" <ji...@apache.org> on 2016/09/12 12:47:20 UTC

[jira] [Updated] (OAK-4785) Move message parsing and handling in separate handlers

     [ https://issues.apache.org/jira/browse/OAK-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Mari updated OAK-4785:
--------------------------------
    Attachment: OAK-4785-01.patch

In the attached patch I untangle {{StandbyServerHandler}} in smaller handlers. These handlers are smaller to understand and implement, and contribute to a leaner pipeline. Moreover, I added a bunch of unit tests for the handlers that are way more fine-grained than the ones currently implemented and don't require external resources (e.g. a file system for the {{FileStore}} or a port for the server).

[~dulceanu], [~marett], do you think this makes sense?

> Move message parsing and handling in separate handlers
> ------------------------------------------------------
>
>                 Key: OAK-4785
>                 URL: https://issues.apache.org/jira/browse/OAK-4785
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: Segment Tar 0.0.12
>
>         Attachments: OAK-4785-01.patch
>
>
> {{StandbyServerHandler}} includes logic for parsing the input messages (passed to the handler as strings), handling the recognised messages and failing in case an error occurs in the process. These tasks should be split in different handlers for ease of understanding and unit testing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)