You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/03/31 17:49:21 UTC
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2835: Opt-in to treat warnings as errors
JaroslavTulach commented on a change in pull request #2835:
URL: https://github.com/apache/netbeans/pull/2835#discussion_r605101715
##########
File path: platform/api.annotations.common/build.xml
##########
@@ -24,79 +24,4 @@
<import file="../../nbbuild/templates/projectized.xml"/>
- <!--
- <target name="findbugs-annotations-init" if="api.annotations.common.findbugs">
- <echo>Building common annotations for usage with FindBugs...</echo>
-
- <property name="src.dir" location="build/generated"/>
- <property name="src.common" location="src"/>
-
- </target>
-
- <target name="build-init" depends="findbugs-annotations-init, projectized.build-init"/>
-
- <target name="compile" depends="findbugs-annotations, projectized-common.compile"/>
-
- <target name="findbugs-annotations" if="api.annotations.common.findbugs" depends="build-init, projectized.findbugs-init">
Review comment:
Welcome back Petr! Looks like the annotations now have `Retention.CLASS` by default: https://bits.netbeans.org/12.3/javadoc/org-netbeans-api-annotations-common/org/netbeans/api/annotations/common/package-summary.html
Otherwise `javac` wouldn't see them when `org-netbeans-api-annotation-commons.jar` is used as a library (which produces the nasty warnings). But probably I should have apply `Retention.CLASS` to `Nonnull`, `TypeQualifierNickname` and `TypeQualifier` as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists