You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/09 15:57:45 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6112: NIFI-10109 Preserve Field Order in JsonTreeReader

exceptionfactory opened a new pull request, #6112:
URL: https://github.com/apache/nifi/pull/6112

   # Summary
   
   [NIFI-10109](https://issues.apache.org/jira/browse/NIFI-10109) Replaces usage of `HashMap` with `LinkedHashMap` in `JsonTreeRowRecordReader` and `MapRecord` to preserve input field order read from input JSON Objects nodes. This approach maintains a deterministic internal representation of objects.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #6112: NIFI-10109 Preserve Field Order in JsonTreeReader

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6112:
URL: https://github.com/apache/nifi/pull/6112#issuecomment-1155685272

   Thanks for the review @emiliosetiadarma!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 merged pull request #6112: NIFI-10109 Preserve Field Order in JsonTreeReader

Posted by GitBox <gi...@apache.org>.
markap14 merged PR #6112:
URL: https://github.com/apache/nifi/pull/6112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] emiliosetiadarma commented on pull request #6112: NIFI-10109 Preserve Field Order in JsonTreeReader

Posted by GitBox <gi...@apache.org>.
emiliosetiadarma commented on PR #6112:
URL: https://github.com/apache/nifi/pull/6112#issuecomment-1155680004

   Was able to run a build that worked well, and run the tests. Was also able to verify that it worked with a sample flow!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #6112: NIFI-10109 Preserve Field Order in JsonTreeReader

Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6112:
URL: https://github.com/apache/nifi/pull/6112#issuecomment-1162356351

   Thanks @exceptionfactory LGTM +1 merged to main
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org