[GitHub] [incubator-echarts] 100pah commented on a change in pull request #10221: Fix #10210 散点图visulMap为piecewise时对数字形式的字符串颜色映射错误

[GitBox <gi...@apache.org>]

100pah commented on a change in pull request #10221: Fix #10210 散点图visulMap为piecewise时对数字形式的字符串颜色映射错误
URL: https://github.com/apache/incubator-echarts/pull/10221#discussion_r272291606
 
 

 ##########
 File path: src/data/List.js
 ##########
 @@ -128,7 +128,7 @@ var List = function (dimensions, hostModel) {
         }
 
         var dimensionName = dimensionInfo.name;
-        dimensionInfo.type = dimensionInfo.type || 'float';
+        dimensionInfo.type = dimensionInfo.type || 'ordinal';
 
 Review comment:
   I am afraid this default value should not be changed.
   `List` is the core module which matters a lot to other features.
   And It has no relationship with the logic of VisualMap.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org