You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2023/03/16 04:20:00 UTC

[jira] [Commented] (FLINK-31464) Move SqlNode conversion logic out from SqlToOperationConverter

    [ https://issues.apache.org/jira/browse/FLINK-31464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700968#comment-17700968 ] 

Jark Wu commented on FLINK-31464:
---------------------------------

I would suggest using Timo's approach proposed in FLINK-31368, because most SqlNodes are not maintained in the Flink repo, and we can't make them extend some converter interface. 

> Move SqlNode conversion logic out from SqlToOperationConverter
> --------------------------------------------------------------
>
>                 Key: FLINK-31464
>                 URL: https://issues.apache.org/jira/browse/FLINK-31464
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Table SQL / Planner
>            Reporter: luoyuxia
>            Priority: Major
>
> Similar to FLINK-31368, the  `SqlToOperationConverter` is a bit bloated. We can refactor it to avoid the code length for this class grow quickly.
> We can follow the idea proposed in FLINK-31368.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)