You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2024/05/17 00:14:30 UTC
[PR] Handle missing VDU better in In QuickJS scanner plugin [couchdb]
nickva opened a new pull request, #5058:
URL: https://github.com/apache/couchdb/pull/5058
Previously we tried to run the VDU query prompt even if there was not VDU. That would have yielded a match anyway as both result in an error, but it added noise to the logs.
Handle the missing VDU like we handle the missing filters in filter_doc_validate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle missing VDU better in In QuickJS scanner plugin [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #5058:
URL: https://github.com/apache/couchdb/pull/5058#issuecomment-2116652251
> Is it worth adding a test for this?
@jaydoane Good idea. Will add a few tests for VDU only, filter only, maps only etc. Will need to check if process proc errors were raised, we record those in `couch_stats` so I'll sample those at the end of the plugin run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle missing VDU better in In QuickJS scanner plugin [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #5058:
URL: https://github.com/apache/couchdb/pull/5058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org