You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2014/09/02 22:03:22 UTC

[jira] [Commented] (HBASE-11797) Create Table interface to replace HTableInterface

    [ https://issues.apache.org/jira/browse/HBASE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118640#comment-14118640 ] 

Hadoop QA commented on HBASE-11797:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12665952/hbase-11797_v4.patch
  against trunk revision .
  ATTACHMENT ID: 12665952

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.curator.test.TestingZooKeeperMain.runFromConfig(TestingZooKeeperMain.java:73)
	at org.apache.curator.test.TestingZooKeeperServer$1.run(TestingZooKeeperServer.java:134)
	at org.apache.oozie.test.MiniHCatServer$1.run(MiniHCatServer.java:137)
	at org.apache.oozie.test.XTestCase$MiniClusterShutdownMonitor.run(XTestCase.java:1042)
	at org.apache.oozie.test.XTestCase.waitFor(XTestCase.java:686)
	at org.apache.oozie.test.XTestCase.sleep(XTestCase.java:704)
	at org.apache.oozie.test.ZKXTestCase$DummyZKOozie.unadvertiseService(ZKXTestCase.java:241)
	at org.apache.oozie.test.ZKXTestCase$DummyZKOozie.teardown(ZKXTestCase.java:265)
	at org.apache.oozie.service.TestHAShareLibService.testShareLibWithHA(TestHAShareLibService.java:165)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10680//console

This message is automatically generated.

> Create Table interface to replace HTableInterface
> -------------------------------------------------
>
>                 Key: HBASE-11797
>                 URL: https://issues.apache.org/jira/browse/HBASE-11797
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Carter
>            Assignee: Carter
>         Attachments: HBASE_11797.patch, HBASE_11797_v2.patch, HBASE_11797_v3.patch, hbase-11797_v4.patch
>
>
> Basically doing this:
> {code}
> interface Table {
>   // get, put related stuff
> }
> @Deprecated
> interface HTableInterface extends Table {
>   // users are encouraged to use the new Table interface
> }
> class HTable extends Table {
>   // all HTable constructors are deprecated
>   // Users are not encouraged to see this class
> }
> {code}
> I'm proposing that in this JIRA I move everything from HTableInterface to Table except the following:
> * Anything deprecated
> * Anything @InterfaceAudience.Private ({{coprocessorService(...)}} and {{batchCoprocessorService(...)}})



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)