You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:31:45 UTC
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #631: feat(hotkey): capture data part3 - declare fine collector
levy5307 commented on a change in pull request #631:
URL: https://github.com/apache/incubator-pegasus/pull/631#discussion_r515813526
##########
File path: src/server/hotkey_collector.cpp
##########
@@ -251,5 +261,111 @@ void hotkey_coarse_data_collector::analyse_data(detect_hotkey_result &result)
}
}
+hotkey_fine_data_collector::hotkey_fine_data_collector(
+ replica_base *base,
+ dsn::replication::hotkey_type::type hotkey_type,
+ int target_bucket_index,
+ int max_queue_size)
+ : internal_collector_base(base),
+ _hotkey_type(hotkey_type),
+ _max_queue_size(max_queue_size),
+ _target_bucket_index(target_bucket_index)
+{
+ // Distinguish between single-threaded and multi-threaded environments
+ if (_hotkey_type == dsn::replication::hotkey_type::READ) {
+
+ auto threads = dsn::get_threadpool_threads_info(THREAD_POOL_LOCAL_APP);
+ int queue_num = threads.size();
+
+ _string_capture_queue_vec.reserve(queue_num);
+ for (int i = 0; i < queue_num; i++) {
+ _thread_queue_map.insert(std::make_pair(threads[i]->native_tid(), i));
+
+ // Create a vector of the ReaderWriterQueue whose size = _max_queue_size
+ _string_capture_queue_vec.emplace_back(_max_queue_size);
+ }
+
Review comment:
remove this line
##########
File path: src/server/hotkey_collector.h
##########
@@ -123,5 +126,31 @@ class hotkey_coarse_data_collector : public internal_collector_base
std::vector<std::atomic<uint64_t>> _hash_buckets;
};
+typedef std::vector<moodycamel::ReaderWriterQueue<std::pair<dsn::blob, uint64_t>>>
+ string_capture_queue_vec;
+
+class hotkey_fine_data_collector : public internal_collector_base
+{
+public:
+ hotkey_fine_data_collector() = delete;
+ explicit hotkey_fine_data_collector(replica_base *base,
+ dsn::replication::hotkey_type::type hotkey_type,
+ int target_bucket_index,
+ int max_queue_size);
+ void capture_data(const dsn::blob &hash_key, uint64_t weight) override;
+ void analyse_data(detect_hotkey_result &result) override;
+
+private:
+ inline int get_queue_index();
+
+ const dsn::replication::hotkey_type::type _hotkey_type;
+ int _max_queue_size;
Review comment:
use uint32_t or uint64_t or uint16_t, ...
##########
File path: src/server/hotkey_collector.h
##########
@@ -123,5 +126,31 @@ class hotkey_coarse_data_collector : public internal_collector_base
std::vector<std::atomic<uint64_t>> _hash_buckets;
};
+typedef std::vector<moodycamel::ReaderWriterQueue<std::pair<dsn::blob, uint64_t>>>
+ string_capture_queue_vec;
+
+class hotkey_fine_data_collector : public internal_collector_base
+{
+public:
+ hotkey_fine_data_collector() = delete;
+ explicit hotkey_fine_data_collector(replica_base *base,
+ dsn::replication::hotkey_type::type hotkey_type,
+ int target_bucket_index,
+ int max_queue_size);
+ void capture_data(const dsn::blob &hash_key, uint64_t weight) override;
+ void analyse_data(detect_hotkey_result &result) override;
+
+private:
+ inline int get_queue_index();
+
+ const dsn::replication::hotkey_type::type _hotkey_type;
+ int _max_queue_size;
Review comment:
use `uint32_t` or `uint64_t` or `uint16_t`, ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org