RE: [GitHub] [airflow] norm commented on a diff in pull request #27829: Improving the release process

[Madilynn Flynn <ma...@clinkz.live>]

Hi,
Just checking, are you interested acquiring the list of attendees? Please respond my email. I'm waiting for your response.
We are discussing about Prices And, provide the discount cost.
Thank you,

-----Original Message-----
From: GitBox <gi...@apache.org> 
Sent: Friday, November 25, 2022 2:05 AM
To: commits@airflow.apache.org
Subject: [GitHub] [airflow] norm commented on a diff in pull request #27829: Improving the release process


norm commented on code in PR #27829:
URL: https://github.com/apache/airflow/pull/27829#discussion_r1032208801


##########
dev/breeze/src/airflow_breeze/utils/confirm.py:
##########
@@ -98,3 +98,20 @@ def user_confirm(
             if quit_allowed:
                 return Answer.QUIT
             sys.exit(1)
+
+
+def user_confirm_bool(

Review Comment:
   Observation: At first glance having the name end `…_bool` didn't make me think it would do any more than return True/False, so having it exit on no/abort was unexpected. But I am also struggling to come up with an alternate name so this isn't a call to action.



--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org