[jira] [Commented] (OOZIE-2546) Imporperly closed resources in OozieDBCLI

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308879#comment-15308879 ] 

Hadoop QA commented on OOZIE-2546:
----------------------------------

Testing JIRA OOZIE-2546

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:red}-1{color} the patch contains 1 line(s) longer than 132 characters
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1782
.    Tests failed: 2
.    Tests errors: 0

.    The patch failed the following testcases:

.      testMemoryUsageAndSpeedOverflowToDisk(org.apache.oozie.service.TestPartitionDependencyManagerEhcache)
.      testMessage_withMixedStatus(org.apache.oozie.command.coord.TestAbandonedCoordChecker)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/2917/

> Imporperly closed resources in OozieDBCLI
> -----------------------------------------
>
>                 Key: OOZIE-2546
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2546
>             Project: Oozie
>          Issue Type: Bug
>          Components: tools
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Trivial
>         Attachments: OOZIE-2546-001.patch
>
>
> Two resources (database and a Writer) are not closed properly in OozieDBCLI. They should be handled in a try-finally block.
> See:
> https://git-wip-us.apache.org/repos/asf?p=oozie.git;a=blob;f=tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java;h=080fc24932d9e84bc38ad7804c9f206845d16d04;hb=master#l997
> https://git-wip-us.apache.org/repos/asf?p=oozie.git;a=blob;f=tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java;h=080fc24932d9e84bc38ad7804c9f206845d16d04;hb=master#l571



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)