You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/01/31 23:54:31 UTC

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints 

khahn@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15146


Change subject: IMPALA-9336: [DOCS] constraints
......................................................................

IMPALA-9336: [DOCS] constraints

CREATE TABLE syntax for primary key and foreign keys spec

Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
---
M docs/topics/impala_create_table.xml
1 file changed, 33 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/15146/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>

[Impala-ASF-CR] IMPALA-9336: [DOCS] Primary and foreign key constraint syntax

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Anurag Mantripragada, Thomas Tauber-Marshall, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15146

to look at the new patch set (#5).

Change subject: IMPALA-9336: [DOCS] Primary and foreign key constraint syntax
......................................................................

IMPALA-9336: [DOCS] Primary and foreign key constraint syntax

CREATE TABLE syntax for primary key and foreign keys spec

Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
---
M docs/topics/impala_create_table.xml
1 file changed, 33 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/15146/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/568/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 05:55:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] Primary and foreign key constraint syntax

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] Primary and foreign key constraint syntax
......................................................................

IMPALA-9336: [DOCS] Primary and foreign key constraint syntax

CREATE TABLE syntax for primary key and foreign keys spec

Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Reviewed-on: http://gerrit.cloudera.org:8080/15146
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M docs/topics/impala_create_table.xml
1 file changed, 33 insertions(+), 6 deletions(-)

Approvals:
  Thomas Tauber-Marshall: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Anurag Mantripragada, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15146

to look at the new patch set (#4).

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................

IMPALA-9336: [DOCS] constraints

CREATE TABLE syntax for primary key and foreign keys spec

Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
---
M docs/topics/impala_create_table.xml
1 file changed, 33 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/15146/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Anurag Mantripragada, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15146

to look at the new patch set (#2).

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................

IMPALA-9336: [DOCS] constraints

CREATE TABLE syntax for primary key and foreign keys spec

Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
---
M docs/topics/impala_create_table.xml
1 file changed, 33 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/15146/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15146/3/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:

http://gerrit.cloudera.org:8080/#/c/15146/3/docs/topics/impala_create_table.xml@147
PS3, Line 147:  
My apologies! I missed a "," after primary key spec. Could you please add a "," here? Thanks!



-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 04:39:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Anurag Mantripragada, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15146

to look at the new patch set (#3).

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................

IMPALA-9336: [DOCS] constraints

CREATE TABLE syntax for primary key and foreign keys spec

Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
---
M docs/topics/impala_create_table.xml
1 file changed, 33 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/15146/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/563/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 23:54:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15146/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15146/4//COMMIT_MSG@7
PS4, Line 7: constraints
Usually we want the first line of the commit to be more descriptive, so maybe something like "primary and foreign key constraint syntax" or similar



-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 18:12:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9336: [DOCS] Primary and foreign key constraint syntax

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] Primary and foreign key constraint syntax
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 18:31:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/567/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 04:20:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/567/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 04:12:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/563/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 00:02:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/564/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Feb 2020 19:50:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 1:

(5 comments)

Thanks for making these changes to the docs. I have a few comments and nits.

http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:

http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@145
PS1, Line 145:   
Nit: I see a few places where there is extra indentation. In Gerrit, this is marked with red. Could you please remove these for consistency?


http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@147
PS1, Line 147: [DISABLE] [NOVALIDATE] [RELY]
DISABLE NOVALIDATE RELY is not common to the entire PK/FK definition, it has to be mentioned in primary key spec as well as EACH foreign key spec.

Maybe this will be more accurate?:

constraint_specification:
  PRIMARY KEY (<varname>col_name</varname>, ...) [DISABLE] [NOVALIDATE] [RELY],[<varname>foreign_key_specification</varname>, ...]

foreign_key_specification:
  FOREIGN KEY (<varname>col_name</varname>, ...) REFERENCES table_name(<varname>col_name</varname>, ...) [DISABLE] [NOVALIDATE] [RELY]


http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@150
PS1, Line 150:  
Nit: Extra indentation


http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@151
PS1, Line 151:   
Nit: Extra indentation


http://gerrit.cloudera.org:8080/#/c/15146/1/docs/topics/impala_create_table.xml@291
PS1, Line 291:     
Nit: Extra indentation



-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Feb 2020 02:35:41 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 4: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/568/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 06:02:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/564/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Feb 2020 19:57:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] Primary and foreign key constraint syntax

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] Primary and foreign key constraint syntax
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 18:34:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 4: Code-Review+1

Looks good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 18:04:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 )

Change subject: IMPALA-9336: [DOCS] constraints
......................................................................


Patch Set 2:

(1 comment)

Thanks for addressing my comments. Another minor change is needed in the spec. I added the comment below.

http://gerrit.cloudera.org:8080/#/c/15146/2/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:

http://gerrit.cloudera.org:8080/#/c/15146/2/docs/topics/impala_create_table.xml@147
PS2, Line 147: [DISABLE] [NOVALIDATE] [RELY]
This should immediately follow primary key specification like so:

PRIMARY KEY (<varname>col_name</varname>, ...)  [DISABLE] [NOVALIDATE] [RELY]
[<varname>foreign_key_specification</varname>, ...]



-- 
To view, visit http://gerrit.cloudera.org:8080/15146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee12da322fbdab7c671c17ceb8436bc3ace2b820
Gerrit-Change-Number: 15146
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <kh...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Feb 2020 22:50:12 +0000
Gerrit-HasComments: Yes