You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/29 07:51:56 UTC
[GitHub] [dubbo-getty] cvictory opened a new pull request #58: Ftr: return the total length and write length
cvictory opened a new pull request #58:
URL: https://github.com/apache/dubbo-getty/pull/58
return the total length and write length in WritePkg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] cvictory commented on a change in pull request #58: Ftr: return the total length and write length
Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #58:
URL: https://github.com/apache/dubbo-getty/pull/58#discussion_r566663842
##########
File path: getty.go
##########
@@ -171,7 +171,9 @@ type Session interface {
// the Writer will invoke this function. Pls attention that if timeout is less than 0, WritePkg will send @pkg asap.
// for udp session, the first parameter should be UDPContext.
- WritePkg(pkg interface{}, timeout time.Duration) error
+ // total: need send total bytes
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks merged pull request #58: Ftr: return the total length and write length
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #58:
URL: https://github.com/apache/dubbo-getty/pull/58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #58: Ftr: return the total length and write length
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #58:
URL: https://github.com/apache/dubbo-getty/pull/58#issuecomment-769641846
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=h1) Report
> Merging [#58](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=desc) (fb8392b) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/3eb8b38bb0572be5e2ac243c7cd9c9874e66b2df?el=desc) (3eb8b38) will **increase** coverage by `0.02%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 68.06% 68.09% +0.02%
==========================================
Files 8 8
Lines 1284 1285 +1
==========================================
+ Hits 874 875 +1
Misses 318 318
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/58/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.46% <71.42%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=footer). Last update [3eb8b38...fb8392b](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #58: Ftr: return the total length and write length
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #58:
URL: https://github.com/apache/dubbo-getty/pull/58#issuecomment-769641846
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=h1) Report
> Merging [#58](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=desc) (0e5e138) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/3eb8b38bb0572be5e2ac243c7cd9c9874e66b2df?el=desc) (3eb8b38) will **increase** coverage by `0.02%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 68.06% 68.09% +0.02%
==========================================
Files 8 8
Lines 1284 1285 +1
==========================================
+ Hits 874 875 +1
Misses 318 318
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/58/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.46% <71.42%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=footer). Last update [3eb8b38...0e5e138](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io commented on pull request #58: Ftr: return the total length and write length
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #58:
URL: https://github.com/apache/dubbo-getty/pull/58#issuecomment-769641846
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=h1) Report
> Merging [#58](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=desc) (e2bdee6) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/3eb8b38bb0572be5e2ac243c7cd9c9874e66b2df?el=desc) (3eb8b38) will **increase** coverage by `0.02%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 68.06% 68.09% +0.02%
==========================================
Files 8 8
Lines 1284 1285 +1
==========================================
+ Hits 874 875 +1
Misses 318 318
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/58/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.46% <71.42%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=footer). Last update [3eb8b38...e2bdee6](https://codecov.io/gh/apache/dubbo-getty/pull/58?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] cvictory commented on a change in pull request #58: Ftr: return the total length and write length
Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #58:
URL: https://github.com/apache/dubbo-getty/pull/58#discussion_r566661999
##########
File path: client_test.go
##########
@@ -170,8 +170,10 @@ func TestTCPClient(t *testing.T) {
func TestUDPClient(t *testing.T) {
var (
- err error
- conn *net.UDPConn
+ err error
+ conn *net.UDPConn
+ leng int
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks commented on a change in pull request #58: Ftr: return the total length and write length
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #58:
URL: https://github.com/apache/dubbo-getty/pull/58#discussion_r566648354
##########
File path: client_test.go
##########
@@ -170,8 +170,10 @@ func TestTCPClient(t *testing.T) {
func TestUDPClient(t *testing.T) {
var (
- err error
- conn *net.UDPConn
+ err error
+ conn *net.UDPConn
+ leng int
Review comment:
leng -> sendLength
##########
File path: getty.go
##########
@@ -171,7 +171,9 @@ type Session interface {
// the Writer will invoke this function. Pls attention that if timeout is less than 0, WritePkg will send @pkg asap.
// for udp session, the first parameter should be UDPContext.
- WritePkg(pkg interface{}, timeout time.Duration) error
+ // total: need send total bytes
Review comment:
// WritePkg: encode package @pkg to bytes steam and send them out
//
// totalBytesLength: @pkg stream bytes length after encoding @pkg.
// sendBytesLength: stream bytes length that sent out successfully.
// error: send out error from system
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org