[GitHub] [storm] 6harat commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

["6harat (via GitHub)" <gi...@apache.org>]

6harat commented on PR #3546:
URL: https://github.com/apache/storm/pull/3546#issuecomment-1595677853

   Please note the following observations / callouts:
   
   1. have not added workerHoosk to executioncontext. AFAIS constructed spouts and bolts are being stored here so as to allow creation of streams later in the flow `FluxBuilder.buildStreamDefinitions`
   2. have not added explicit type descriptors as being done for spouts, bolts and includes in `FluxParser.yaml`. AFAIU the info provided in TopologyDef is more than enough to parse yaml containing `workerHooks` field.
   
   Let me know if my understanding was incorrect and a change is indeed required on the above files. Will pick it up right away.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org