You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/28 12:09:23 UTC
[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #20: Updates github workflows to follow other projects
mdedetrich commented on code in PR #20:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/20#discussion_r1119968022
##########
.github/workflows/checks.yml:
##########
@@ -0,0 +1,73 @@
+name: Basic checks
+
+on:
+ pull_request:
+ push:
+ branches:
+ - main
+ - release-*
+ tags-ignore: [ v.* ]
+
+jobs:
+ check-code-style:
+ name: Check Code Style
+ if: github.repository == 'apache/incubator-pekko-persistence-cassandra'
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+
+ - name: Checkout GitHub merge
+ if: github.event.pull_request
+ run: |-
+ git fetch origin pull/${{ github.event.pull_request.number }}/merge:scratch
+ git checkout scratch
+
+ - name: Setup Java 11
+ uses: actions/setup-java@v3
+ with:
+ distribution: temurin
+ java-version: 11
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: Compilation and binary-compatibility check
+ run: sbt "verifyCodeStyle; +Test/compile" # todo: add mimaReportBinaryIssues
+
+
+ check-docs::
+ name: ScalaDoc, Documentation with Paradox
+ if: github.repository == 'apache/incubator-pekko-persistence-cassandra'
+ runs-on: ubuntu-20.04
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+
+ - name: Checkout GitHub merge
+ if: github.event.pull_request
+ run: |-
+ git fetch origin pull/${{ github.event.pull_request.number }}/merge:scratch
+ git checkout scratch
+
+ - name: Setup Java 11
+ uses: actions/setup-java@v3
+ with:
+ distribution: temurin
+ java-version: 11
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: Create all API docs for artifacts/website and all reference docs
+ run: sbt "unidoc; docs/paradox"
Review Comment:
nit: New line
##########
.github/workflows/unit-tests.yml:
##########
@@ -0,0 +1,55 @@
+name: Unit Tests
+
+on:
+ pull_request:
+ push:
+ branches:
+ - main
+ - release-*
+ tags-ignore: [ v.* ]
+ schedule:
+ - cron: '0 2 * * *' # every day 2am
+
+jobs:
+ test:
+ name: Test
+ if: github.repository == 'apache/incubator-pekko-persistence-cassandra'
+ runs-on: ubuntu-20.04
+
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - { jdk: '8', container: "cassandra-latest", scalaVersion: "++2.13.10", test: "test" }
+ - { jdk: '11', container: "cassandra-latest", scalaVersion: "++2.12.17", test: "test" }
+ - { jdk: '11', container: "cassandra-latest", scalaVersion: "++2.13.10", test: "test" }
+ - { jdk: '11', container: "cassandra2", scalaVersion: "++2.13.10", test: "'testOnly -- -l RequiresCassandraThree'"}
+ - { jdk: '11', container: "cassandra3", scalaVersion: "++2.13.10", test: "test" }
+
+ env:
+ JAVA_OPTS: -Xms2G -Xmx2G -Xss2M -XX:ReservedCodeCacheSize=256M -Dfile.encoding=UTF-8
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+
+ - name: Checkout GitHub merge
+ if: github.event.pull_request
+ run: |-
+ git fetch origin pull/${{ github.event.pull_request.number }}/merge:scratch
+ git checkout scratch
+
+ - name: Setup Java ${{ matrix.jdk }}
+ uses: actions/setup-java@v3
+ with:
+ distribution: temurin
+ java-version: ${{ matrix.jdk }}
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6.4.0
+
+ - name: Test against ${{ matrix.container }}
+ run: |-
+ docker-compose up -d ${{ matrix.container }} && sbt ${{ matrix.scalaVersion }} ${{matrix.test}}
Review Comment:
nit: New line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org