You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/02/24 03:11:25 UTC
[PR] fix(build): restore automatic .d.ts generation in dev mode [superset]
rusackas opened a new pull request, #38202:
URL: https://github.com/apache/superset/pull/38202
### SUMMARY
Re-enables `build: true` and `mode: 'write-references'` on `ForkTsCheckerWebpackPlugin` so that `.d.ts` files are generated automatically during webpack dev builds. This removes the need for developers to manually run `npm run plugins:build` after every change.
**Background:** PR #35946 (SWC migration) originally added these settings as essential for the dev workflow. PR #37771 had to remove them because story files that import from `@storybook-shared` (a webpack alias to `.storybook/shared/`) cause `rootDir` errors — each plugin tsconfig has `rootDir: "src"`, but `@storybook-shared` resolves outside that directory.
**Fix:** `ForkTsCheckerWebpackPlugin` supports `configOverwrite.exclude`, which is applied per-project during `--build` traversal. By excluding `**/*.stories.*` (and `**/*.test.*`), TypeScript never processes story files and thus never attempts to resolve `@storybook-shared`, eliminating the `rootDir` conflict. The existing plugin tsconfigs already exclude stories via their own `exclude` arrays — this change ensures the webpack plugin respects the same exclusion.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — build tooling change, no UI impact.
### TESTING INSTRUCTIONS
1. Run `npm run dev-server` (or `npm run dev`) in `superset-frontend/`
2. Verify the dev server starts without TypeScript rootDir errors
3. Modify a TypeScript file in a plugin (e.g., `plugins/plugin-chart-echarts/src/`)
4. Verify `.d.ts` files are generated in the plugin's `lib/` directory without needing to run `npm run plugins:build`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(build): restore automatic .d.ts generation in dev mode [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38202:
URL: https://github.com/apache/superset/pull/38202#issuecomment-3948653323
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(build): restore automatic .d.ts generation in dev mode [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #38202:
URL: https://github.com/apache/superset/pull/38202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(build): restore automatic .d.ts generation in dev mode [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #38202:
URL: https://github.com/apache/superset/pull/38202#issuecomment-3948668288
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2cd64e63005ab68ac4020a866dfa91ec22d23053 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/699d16de4dec2f000838181e |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-38202--superset-docs-preview.netlify.app](https://deploy-preview-38202--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-38202--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org