You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/11 09:48:05 UTC

Review Request: "Unset" LIBPROCESS_PORT before applying executor/command environment variables (in the event they modify it).

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7539/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Description
-------

See summary.


Diffs
-----

  src/launcher/launcher.cpp 5de1f479cf03182a1c12bdd951b5bd57c00ee2ee 

Diff: https://reviews.apache.org/r/7539/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request: "Unset" LIBPROCESS_PORT before applying executor/command environment variables (in the event they modify it).

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7539/#review12370
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7539/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 7:48 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.cpp 5de1f479cf03182a1c12bdd951b5bd57c00ee2ee 
> 
> Diff: https://reviews.apache.org/r/7539/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: "Unset" LIBPROCESS_PORT before applying executor/command environment variables (in the event they modify it).

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7539/#review12333
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7539/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 7:48 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.cpp 5de1f479cf03182a1c12bdd951b5bd57c00ee2ee 
> 
> Diff: https://reviews.apache.org/r/7539/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>