You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 11:57:50 UTC
[GitHub] [arrow-rs] Ted-Jiang opened a new pull request, #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Ted-Jiang opened a new pull request, #3047:
URL: https://github.com/apache/arrow-rs/pull/3047
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3003.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1017134294
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
}
}
+// Combine two lists of `RowSelection` return the intersection of them
Review Comment:
I recommend we put this function in parquet/src/arrow/arrow_reader/selection.rs
that way it is logically grouped with similar functionality as well as is in the same module as the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1017957199
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
}
}
+// Combine two lists of `RowSelection` return the intersection of them
Review Comment:
@alamb I used to put it in `selection.rs` [refactor avoid pub mod](https://github.com/apache/arrow-rs/pull/3047/commits/7627627be8e82850a7e64414c1a347cbda18053b),
but it need pub the `selection` mod avoid method not used, it this ok?🤔 or any method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1018602077
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
}
}
+// Combine two lists of `RowSelection` return the intersection of them
Review Comment:
> Perhaps you could extend
>
> https://github.com/apache/arrow-rs/blob/4f525fe/parquet/src/arrow/arrow_reader/mod.rs#L46
>
> ```rust
> pub use selection::{RowSelection, RowSelector};
> ```
>
> to
>
> ```rust
> pub use selection::{intersect_row_selections, RowSelection, RowSelector};
> ```
>
> So it is exposed?
@alamb 😂 yes, thanks notice its ok only one method in one private mod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1019589474
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
}
}
+// Combine two lists of `RowSelection` return the intersection of them
Review Comment:
I don't have a strong opinion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1018237136
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
}
}
+// Combine two lists of `RowSelection` return the intersection of them
Review Comment:
Perhaps you could extend
https://github.com/apache/arrow-rs/blob/4f525fe/parquet/src/arrow/arrow_reader/mod.rs#L46
```rust
pub use selection::{RowSelection, RowSelector};
```
to
```rust
pub use selection::{intersect_row_selections, RowSelection, RowSelector};
```
So it is exposed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1018599235
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
}
}
+// Combine two lists of `RowSelection` return the intersection of them
Review Comment:
> Or perhaps we could rework this method as a member function on RowSelection? i.e. `fn intersection(&self, other: &RowSelection) -> RowSelection` ?
This is a good idea , but it may call `from(selectors: Vec<RowSelector>)` more times🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1016530063
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -40,7 +40,7 @@ use crate::file::serialized_reader::ReadOptionsBuilder;
use crate::schema::types::SchemaDescriptor;
mod filter;
-mod selection;
+pub mod selection;
Review Comment:
because
```
function `intersect_row_selection` is never used
```
I make this mod pub, i think this is ok🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1018491335
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
}
}
+// Combine two lists of `RowSelection` return the intersection of them
Review Comment:
Or perhaps we could rework this method as a member function on RowSelection? i.e. `fn intersection(&self, other: &RowSelection) -> RowSelection` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#issuecomment-1310941027
Benchmark runs are scheduled for baseline = 4dd7fea13dd2ac62f179fc7fc245037e7036afc9 and contender = 9f14683313bd87e72344cdeb6b35201943fdbcb4. 9f14683313bd87e72344cdeb6b35201943fdbcb4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b0dcd5f847a34063928548cdea58fe3f...100f41d3341546db9dcfc1bce2b5fea0/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/585328fad2cc4f48b4dbaf89ec5d9455...22fa63f8de8742c08cc0269d8f5a626f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/487b0951980449c890e3f691ca7e1035...a27a4a8bbd284eeaaa9cf8940e14fde8/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/22408afac2094d509aec4db0454cec9d...982ed6dbb93c48ecbcaac165bc939ae2/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org