You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2017/12/28 07:57:01 UTC
[GitHub] codecov-io commented on issue #234: SCB-127 Bug fix: Can not discovery the same domain service instances.
codecov-io commented on issue #234: SCB-127 Bug fix: Can not discovery the same domain service instances.
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/234#issuecomment-354246402
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234?src=pr&el=h1) Report
> Merging [#234](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/dec81c0872de6471b78b9af8c5b90319c3195072?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234/graphs/tree.svg?src=pr&width=650&token=GAaF7zrg8R&height=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 68.72% 68.86% +0.14%
==========================================
Files 17 17
Lines 3562 3562
==========================================
+ Hits 2448 2453 +5
+ Misses 938 935 -3
+ Partials 176 174 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234?src=pr&el=tree) | Coverage ? | |
|---|---|---|
| [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `70.38% <100%> (-0.17%)` | :arrow_down: |
| [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `74.41% <0%> (+0.58%)` | :arrow_up: |
| [server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==) | `73.63% <0%> (+0.78%)` | :arrow_up: |
| [server/service/service\_dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZV9kZXBlbmRlbmN5Lmdv) | `75.86% <0%> (+0.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234?src=pr&el=footer). Last update [dec81c0...cfda1a6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services