[GitHub] [pulsar] RobertIndie commented on a diff in pull request #15321: [improve][client] Should use CompletableFuture#get(long, TimeUnit)

[GitBox <gi...@apache.org>]

RobertIndie commented on code in PR #15321:
URL: https://github.com/apache/pulsar/pull/15321#discussion_r858750335


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java:
##########
@@ -84,7 +84,7 @@ public MessageId send() throws PulsarClientException {
                 producer.triggerFlush();
             }
 
-            return sendFuture.get();
+            return sendFuture.get(Integer.MAX_VALUE, TimeUnit.MILLISECONDS);

Review Comment:
   @haoyann Let's also add this detail to the PR description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org