You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2004/12/10 02:53:11 UTC

Re: svn commit: r12235 - in branches/locking/subversion: include tests tests/libsvn_delta tests/libsvn_diff tests/libsvn_fs tests/libsvn_fs_base tests/libsvn_repos tests/libsvn_subr tests/libsvn_wc

fitz@tigris.org wrote:

>Author: fitz
>Date: Tue Dec  7 22:58:31 2004
>New Revision: 12235
>  
>

>Log:
>Change the C testsuite to allow testing of the fsfs backend by passing
>--fstype=fsfs.
>  
>
Typo here? Should probably be --fs-type.

>* subversion/tests/libsvn_fs/run-fs-tests.py: Fix call to run-tests to
>  run locks-test.
>  
>
Question:

>Modified: branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py
>Url: http://svn.collab.net/viewcvs/svn/branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py?view=diff&rev=12235&p1=branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py&r1=12234&p2=branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py&r2=12235
>==============================================================================
>--- branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py	(original)
>+++ branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py	Tue Dec  7 22:58:31 2004
>@@ -9,8 +9,7 @@
> 
> # Run the tests
> import exectest
>-errors = exectest.run_tests(['key-test', 'skel-test',
>-                             'strings-reps-test', 'fs-test'])
>+errors = exectest.run_tests(['locks-test'])
> sys.exit(errors)
>  
>
Why disable the other tests?


Otherwise, nice work! We've needed this, like, forever.

-- Brane



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12235 - in branches/locking/subversion: include tests tests/libsvn_delta tests/libsvn_diff tests/libsvn_fs tests/libsvn_fs_base tests/libsvn_repos tests/libsvn_subr tests/libsvn_wc

Posted by Branko Čibej <br...@xbc.nu>.
Brian W. Fitzpatrick wrote:

> Thanks!  I greatly prefer test driven development, so it's a purely  
> selfish move. :-)

As far as I'm concerned, you can be as selfish as you like if this is a 
typical result of your selfishness. :-)

-- Brane




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12235 - in branches/locking/subversion: include tests tests/libsvn_delta tests/libsvn_diff tests/libsvn_fs tests/libsvn_fs_base tests/libsvn_repos tests/libsvn_subr tests/libsvn_wc

Posted by "Brian W. Fitzpatrick" <fi...@collab.net>.
On Dec 9, 2004, at 8:53 PM, Branko Čibej wrote:

> fitz@tigris.org wrote:
>
>> Author: fitz
>> Date: Tue Dec  7 22:58:31 2004
>> New Revision: 12235
>>
>
>> Log:
>> Change the C testsuite to allow testing of the fsfs backend by passing
>> --fstype=fsfs.
>>
> Typo here? Should probably be --fs-type.

Yep, a typo.

>> * subversion/tests/libsvn_fs/run-fs-tests.py: Fix call to run-tests to
>>  run locks-test.
>>
> Question:
>
>> Modified: branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py
>> Url:  
>> http://svn.collab.net/viewcvs/svn/branches/locking/subversion/tests/ 
>> libsvn_fs/run-fs-tests.py?view=diff&rev=12235&p1=branches/locking/ 
>> subversion/tests/libsvn_fs/run-fs-tests.py&r1=12234&p2=branches/ 
>> locking/subversion/tests/libsvn_fs/run-fs-tests.py&r2=12235
>> ====================================================================== 
>> ========
>> ---  
>> branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py	 
>> (original)
>> +++ branches/locking/subversion/tests/libsvn_fs/run-fs-tests.py	Tue  
>> Dec  7 22:58:31 2004
>> @@ -9,8 +9,7 @@
>> # Run the tests
>> import exectest
>> -errors = exectest.run_tests(['key-test', 'skel-test',
>> -                             'strings-reps-test', 'fs-test'])
>> +errors = exectest.run_tests(['locks-test'])
>> sys.exit(errors)
>>
> Why disable the other tests?

They're not disabled--it was a cut-and-paste error from when I copied  
the script from tests/libsvn_fs_base.  Those tests still take place  
over there--tho I'd like to move any non-bdb specific tests into this  
directory at some point in the future.

> Otherwise, nice work! We've needed this, like, forever.

Thanks!  I greatly prefer test driven development, so it's a purely  
selfish move. :-)

-Fitz