You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/07 13:41:00 UTC
[jira] [Commented] (IMAGING-188) ICNS Image Parser: Support for
large Icons (ic07, ic08, ic09, ic10 [128px, 256px, 512px, 1024px]) and JPEG
2000
[ https://issues.apache.org/jira/browse/IMAGING-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281855#comment-16281855 ]
ASF GitHub Bot commented on IMAGING-188:
----------------------------------------
GitHub user DasBueroAmDraht opened a pull request:
https://github.com/apache/commons-imaging/pull/34
IMAGING-188
https://issues.apache.org/jira/browse/IMAGING-188
commits:
- support for all icns types listed on wikipedia: https://en.wikipedia.org/wiki/Apple_Icon_Image_format
- support for JPEG 2000 via modified ImageIO Library, look at the new entry in the pom
- test for the enhanced IcnsDecoder, plus test files (extracts images of all icns-types from several icns files)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DasBueroAmDraht/commons-imaging IMAGING-188
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-imaging/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit 1e3f0ebd28aa7736facd3dfc079db6a25d884c13
Author: Marco Wagner <mw...@dasburo.com>
Date: 2017-12-07T13:33:50Z
IMAGING-188: ICNS Image Parser: Support for large Icons (ic07, ic08, ic09, ic10 [128px, 256px, 512px, 1024px]) and JPEG 2000
- support for all icns types listed on wikipedia: https://en.wikipedia.org/wiki/Apple_Icon_Image_format
- support for JPEG 2000 via modified ImageIO Library, look at the new entry in the pom
commit 121ea21f16120842a91aacc0678becedbd9e67ee
Author: Marco Wagner <mw...@dasburo.com>
Date: 2017-12-07T13:36:57Z
IMAGING-188: ICNS Image Parser: Support for large Icons (ic07, ic08, ic09, ic10 [128px, 256px, 512px, 1024px]) and JPEG 2000
- test for the enhanced IcnsDecoder, plus test files (extracts images of all icns-types from several icns files)
----
> ICNS Image Parser: Support for large Icons (ic07, ic08, ic09, ic10 [128px, 256px, 512px, 1024px]) and JPEG 2000
> ---------------------------------------------------------------------------------------------------------------
>
> Key: IMAGING-188
> URL: https://issues.apache.org/jira/browse/IMAGING-188
> Project: Commons Imaging
> Issue Type: New Feature
> Affects Versions: 1.0
> Environment: OS X
> Reporter: Marco Wagner
>
> I needed larger icons of icns files, than currently extracted with the Apache Commons Imaging ICNS Image Parser/ICNS Decoder.
> So I edited the Source Code:
> In case an icns element is a PNG (depends on 0-4th byte [header]),
> the bytes can be put in a ByteArrayInputStream and then read by ImageIO.read, that returns the BufferedImage needed.
> Then it can be added to the list of List<BufferedImage> in IcnsDecoder#decodeAllImages().
> InputStream in = new ByteArrayInputStream(imageData);
> BufferedImage image = ImageIO.read(in);
> To the enum IcnsType I added:
> ICNS_256x256_32BIT_ARGB_IMAGE("ic08", 256, 256, 32, false),
> ICNS_512x512_32BIT_ARGB_IMAGE("ic09", 512, 512, 32, false),
> ICNS_1024x1024_32BIT_ARGB_IMAGE("ic10", 1024, 1024, 32, false);
> https://en.wikipedia.org/wiki/Apple_Icon_Image_format
> No need for Rle24Compression.decompress() or decode32BPPImage().
> I can upload the code somewhere, please tell me how to do.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)