[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16131: [fix][python client] Fixed schema validate_type method throw a wrong exception

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #16131:
URL: https://github.com/apache/pulsar/pull/16131#discussion_r901774301


##########
pulsar-client-cpp/python/pulsar/schema/definition.py:
##########
@@ -444,8 +444,8 @@ def validate_type(self, name, val):
 
         for x in val:
             if type(x) != self.array_type.python_type():
-                raise TypeError('Array field ' + name + ' items should all be of type '
-                                + self.array_type.python_type())
+                raise TypeError('Array field ' + name + ' items should all be of type ' +
+                                str(self.array_type.type()))

Review Comment:
   ```suggestion
                                   self.array_type.type())
   ```
   
   The `type()` method already returns a `str`, there is no need to cast it to `str`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org