You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/29 04:13:56 UTC
Review Request 38837: CMake: Disable slave build on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Disable slave build on Windows.
Diffs
-----
CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
Diff: https://reviews.apache.org/r/38837/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 38837: CMake: Disable agent build on Windows.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/#review101033
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38825, 38826, 38827, 38837]
All tests passed.
- Mesos ReviewBot
On Sept. 29, 2015, 8:21 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38837/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 8:21 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Disable slave build on Windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
>
> Diff: https://reviews.apache.org/r/38837/diff/
>
>
> Testing
> -------
>
> # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
>
> cmake .. -DENABLE_LIBEVENT=1 && make -j 8
> cmake .. && make -j 8
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38837: CMake: Disable agent build on Windows.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/#review101416
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 29, 2015, 8:21 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38837/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 8:21 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Disable slave build on Windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
>
> Diff: https://reviews.apache.org/r/38837/diff/
>
>
> Testing
> -------
>
> # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
>
> cmake .. -DENABLE_LIBEVENT=1 && make -j 8
> cmake .. && make -j 8
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38837: CMake: Disable agent build on Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 8:21 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Disable slave build on Windows.
Diffs (updated)
-----
CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
Diff: https://reviews.apache.org/r/38837/diff/
Testing
-------
# On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
cmake .. -DENABLE_LIBEVENT=1 && make -j 8
cmake .. && make -j 8
Thanks,
Alex Clemmer
Re: Review Request 38837: CMake: Disable agent build on Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 5:17 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Disable slave build on Windows.
Diffs
-----
CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
Diff: https://reviews.apache.org/r/38837/diff/
Testing (updated)
-------
# On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
cmake .. -DENABLE_LIBEVENT=1 && make -j 8
cmake .. && make -j 8
Thanks,
Alex Clemmer
Re: Review Request 38837: CMake: Disable agent build on Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Sept. 29, 2015, 5:06 p.m., Joseph Wu wrote:
> > Can you explain why you're disabling this part? (Is it simply not implemented yet, so you're temporarily skipping it?)
Mainly because the agent doesn't actually compile on Windows. I meant to put this up for review awhile ago but forgot. I'll open this up again to Windows in a few weeks when we are ready to do it for real.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/#review100974
-----------------------------------------------------------
On Sept. 29, 2015, 5:17 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38837/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 5:17 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Disable slave build on Windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
>
> Diff: https://reviews.apache.org/r/38837/diff/
>
>
> Testing
> -------
>
> # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
>
> cmake .. -DENABLE_LIBEVENT=1 && make -j 8
> cmake .. && make -j 8
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38837: CMake: Disable agent build on Windows.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/#review100974
-----------------------------------------------------------
Can you explain why you're disabling this part? (Is it simply not implemented yet, so you're temporarily skipping it?)
- Joseph Wu
On Sept. 29, 2015, 9:49 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38837/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 9:49 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Disable slave build on Windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
>
> Diff: https://reviews.apache.org/r/38837/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38837: CMake: Disable agent build on Windows.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 4:49 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Summary (updated)
-----------------
CMake: Disable agent build on Windows.
Repository: mesos
Description
-------
CMake: Disable slave build on Windows.
Diffs
-----
CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
Diff: https://reviews.apache.org/r/38837/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 38837: CMake: Disable slave build on Windows.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38837/#review100933
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38825, 38826, 38827, 38837]
All tests passed.
- Mesos ReviewBot
On Sept. 29, 2015, 2:13 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38837/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 2:13 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Disable slave build on Windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt c866f6d85d629ca9c3a987fa2c652bc63a7ff1be
>
> Diff: https://reviews.apache.org/r/38837/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>