You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/19 20:02:07 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #9586: [mypy] Enforcing typing for a number of modules

codecov-io commented on issue #9586: [mypy] Enforcing typing for a number of modules
URL: https://github.com/apache/incubator-superset/pull/9586#issuecomment-616216217
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9586?src=pr&el=h1) Report
   > Merging [#9586](https://codecov.io/gh/apache/incubator-superset/pull/9586?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/636ee5d19af09debe49a45389ba97d12b3569e1f&el=desc) will **decrease** coverage by `6.87%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9586/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9586?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9586      +/-   ##
   ==========================================
   - Coverage   65.63%   58.75%   -6.88%     
   ==========================================
     Files         574      392     -182     
     Lines       30079    12414   -17665     
     Branches     3054     3054              
   ==========================================
   - Hits        19742     7294   -12448     
   + Misses      10153     4936    -5217     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `58.75% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9586?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9fX2luaXRfXy5weQ==) | | |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | | |
   | [superset/connectors/sqla/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL19faW5pdF9fLnB5) | | |
   | [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | | |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | | |
   | [superset/models/user\_attributes.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3VzZXJfYXR0cmlidXRlcy5weQ==) | | |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | | |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | | |
   | ... and [161 more](https://codecov.io/gh/apache/incubator-superset/pull/9586/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9586?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9586?src=pr&el=footer). Last update [636ee5d...e0e6917](https://codecov.io/gh/apache/incubator-superset/pull/9586?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org