You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/05/10 08:59:11 UTC

[GitHub] [arrow] thisisnic opened a new pull request, #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

thisisnic opened a new pull request, #35523:
URL: https://github.com/apache/arrow/pull/35523

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35523:
URL: https://github.com/apache/arrow/pull/35523#issuecomment-1541778556

   Revision: 0f257024a780b7775f908d70421903a62d435e28
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-db1c4f51ea](https://github.com/ursacomputing/crossbow/branches/all?query=actions-db1c4f51ea)
   
   |Task|Status|
   |----|------|
   |conda-linux-aarch64-cpu-r42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-conda-linux-aarch64-cpu-r42)](https://github.com/ursacomputing/crossbow/tree/actions-db1c4f51ea-azure-conda-linux-aarch64-cpu-r42)|
   |conda-linux-x64-cpu-r42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-conda-linux-x64-cpu-r42)](https://github.com/ursacomputing/crossbow/runs/13369380100)|
   |conda-osx-arm64-cpu-r42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-conda-osx-arm64-cpu-r42)](https://github.com/ursacomputing/crossbow/runs/13369367552)|
   |conda-osx-x64-cpu-r42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-conda-osx-x64-cpu-r42)](https://github.com/ursacomputing/crossbow/runs/13369380908)|
   |conda-win-x64-cpu-r41|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-conda-win-x64-cpu-r41)](https://github.com/ursacomputing/crossbow/runs/13369368691)|
   |homebrew-r-autobrew|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-homebrew-r-autobrew)](https://github.com/ursacomputing/crossbow/actions/runs/4935403507/jobs/8821664948)|
   |homebrew-r-brew|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-homebrew-r-brew)](https://github.com/ursacomputing/crossbow/actions/runs/4935402807/jobs/8821662982)|
   |r-binary-packages|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-r-binary-packages)](https://github.com/ursacomputing/crossbow/actions/runs/4935407161/jobs/8821672643)|
   |test-fedora-r-clang-sanitizer|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-fedora-r-clang-sanitizer)](https://github.com/ursacomputing/crossbow/runs/13369377226)|
   |test-r-arrow-backwards-compatibility|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-arrow-backwards-compatibility)](https://github.com/ursacomputing/crossbow/actions/runs/4935409699/jobs/8821678135)|
   |test-r-depsource-bundled|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-depsource-bundled)](https://github.com/ursacomputing/crossbow/runs/13369382683)|
   |test-r-depsource-system|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-depsource-system)](https://github.com/ursacomputing/crossbow/actions/runs/4935404658/jobs/8821666832)|
   |test-r-dev-duckdb|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-dev-duckdb)](https://github.com/ursacomputing/crossbow/actions/runs/4935410289/jobs/8821679221)|
   |test-r-devdocs|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-devdocs)](https://github.com/ursacomputing/crossbow/actions/runs/4935402180/jobs/8821662120)|
   |test-r-gcc-11|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-gcc-11)](https://github.com/ursacomputing/crossbow/actions/runs/4935405545/jobs/8821668737)|
   |test-r-gcc-12|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-gcc-12)](https://github.com/ursacomputing/crossbow/actions/runs/4935407408/jobs/8821673360)|
   |test-r-install-local|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions/runs/4935405997/jobs/8821670058)|
   |test-r-install-local-minsizerel|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-install-local-minsizerel)](https://github.com/ursacomputing/crossbow/actions/runs/4935403199/jobs/8821663959)|
   |test-r-library-r-base-latest|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-library-r-base-latest)](https://github.com/ursacomputing/crossbow/runs/13369383697)|
   |test-r-linux-as-cran|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/4935406510/jobs/8821671608)|
   |test-r-linux-rchk|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-linux-rchk)](https://github.com/ursacomputing/crossbow/actions/runs/4935402436/jobs/8821662268)|
   |test-r-linux-valgrind|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-linux-valgrind)](https://github.com/ursacomputing/crossbow/runs/13369374924)|
   |test-r-minimal-build|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-minimal-build)](https://github.com/ursacomputing/crossbow/runs/13369370786)|
   |test-r-offline-maximal|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-offline-maximal)](https://github.com/ursacomputing/crossbow/actions/runs/4935404059/jobs/8821665633)|
   |test-r-offline-minimal|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-offline-minimal)](https://github.com/ursacomputing/crossbow/runs/13369381729)|
   |test-r-rhub-debian-gcc-devel-lto-latest|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-rhub-debian-gcc-devel-lto-latest)](https://github.com/ursacomputing/crossbow/runs/13369363714)|
   |test-r-rhub-debian-gcc-release-custom-ccache|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-rhub-debian-gcc-release-custom-ccache)](https://github.com/ursacomputing/crossbow/runs/13369372876)|
   |test-r-rhub-ubuntu-gcc-release-latest|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-rhub-ubuntu-gcc-release-latest)](https://github.com/ursacomputing/crossbow/runs/13369376250)|
   |test-r-rstudio-r-base-4.3-centos7-devtoolset-8|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-rstudio-r-base-4.3-centos7-devtoolset-8)](https://github.com/ursacomputing/crossbow/runs/13369374186)|
   |test-r-rstudio-r-base-4.3-focal|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-rstudio-r-base-4.3-focal)](https://github.com/ursacomputing/crossbow/runs/13369369972)|
   |test-r-rstudio-r-base-4.3-opensuse153|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-r-rstudio-r-base-4.3-opensuse153)](https://github.com/ursacomputing/crossbow/runs/13369362062)|
   |test-r-ubuntu-22.04|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-ubuntu-22.04)](https://github.com/ursacomputing/crossbow/actions/runs/4935401809/jobs/8821661308)|
   |test-r-versions|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-db1c4f51ea-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions/runs/4935405111/jobs/8821668473)|
   |test-ubuntu-r-sanitizer|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-db1c4f51ea-azure-test-ubuntu-r-sanitizer)](https://github.com/ursacomputing/crossbow/runs/13369373493)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] nealrichardson commented on a diff in pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1195689196


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   Do we still need to test on rtools 42? I don't know the difference between 42 and 43 to know if not having any jobs that use it is a risk.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] thisisnic commented on a diff in pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1318992585


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   > What about nightly packages?
   
   How do you mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1355007632


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   I don't think we should drop the 32-bit build unless we run into a situation where the build fails and we don't have the developer time to fix it. I don't think either of those things are true right now? We definitely still want to support the same as the tidyverse support policy within the limits of our developer capacity...old R is very common in government and on supercomputer/cluster environments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1355548032


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   So (as we are following the past-4 rule I guess?) we will drop the 32bit build when 4.6 is released (aka in 3! years)?  My only reason to drop it is shortening of build times, as we build 3 libarrow versions in each windows build so :shrug:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1355028202


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   RSPM provides binary builds for older Windows (I just checked, and `install.packages("arrow")` on Windows/R 4.0.6 gives the latest version without an attempted source build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35523:
URL: https://github.com/apache/arrow/pull/35523#issuecomment-1541619583

   * Closes: #35392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1355575292


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   Valid concern, though in regular CI we only build the ucrt64 version, the 32-bit is only nightly, so the build time is less of an issue there. (I think the libarrow builds are also parallelized.)
   
   That said, we already "violate" the tidyverse standard for version compatibility (Windows only) because we require R 4.0 on Windows due to C++17. 
   
   I think I'm landing in the same place as @paleolimbot here: leave it in unless/until the 32-bit builds are causing undue developer burden, which it seems like today they are not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35523:
URL: https://github.com/apache/arrow/pull/35523#issuecomment-1541619633

   :warning: GitHub issue #35392 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] thisisnic commented on pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #35523:
URL: https://github.com/apache/arrow/pull/35523#issuecomment-1710617260

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1355143676


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   I don't think it will cause a problem, but worth asking on the mailing list. Alternatively, you could just leave it in as long as it's not costing you development time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] thisisnic commented on pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #35523:
URL: https://github.com/apache/arrow/pull/35523#issuecomment-1541761147

   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] assignUser commented on a diff in pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1195775587


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   >From the user perspective, Rtools43 is the same as Rtools42. It uses newer versions of the compiler toolchain and libraries, and hence some package authors will have to extend their make files to link additional libraries. Maintainers of CRAN and Bioconductor packages may use [these patches](https://www.r-project.org/nosvn/winutf8/ucrt3/patches/) for reference or re-use them in their code.
   
   Does not look like there are any changes that affect us, so we can probably just update to 43?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] assignUser commented on a diff in pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1339321504


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   I just  tried to update the version used in nightly packages and that's a no go for now (at least for the 10.13 runner...) as rig doesn't find 4.3 due to url change and even compiling from source I was unable to make any newer rig versions run on 10.13. We could do symlinking by hand or something but I'd rather not... hopefully we will be able to drop 10.13 soon :crossed_fingers: 
   
   Also another thing regarding rtools: do we want to continure building urct + 32/64 bit versions of libarrow? imo it would be sensible to drop at the minimum the 32 bit build... but we don't really have a support policy so :shrug: (something I plan to bring up on the ml again) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] thisisnic commented on pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #35523:
URL: https://github.com/apache/arrow/pull/35523#issuecomment-1541620298

   Not sure that everything is expected to work here yet as https://cloud.r-project.org/bin/linux/ubuntu/ hasn't been updated to mention 4.3 (could be a docs issue, but perhaps not).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #35523:
URL: https://github.com/apache/arrow/pull/35523#issuecomment-1786116746

   @github-actions autotune


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1355014495


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   The argument in favor of dropping the 32-bit builds would be that CRAN only host binaries for current and oldrel, and it's not really feasible for Windows users to install packages from source, so those on older R versions won't be able to install the latest arrow package anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1355136650


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   Well then people who want to use arrow on old versions on windows can use RSPM? I am strongly +1 on dropping 32bit support. Win 7 has been eol for 3 years and I don't think it is our responsibility to support such outdated configurations. I would also assume that the percentage of users that use this is rather small? So not worth it from that direction either (compare to java 8 discussion on the ml)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] nealrichardson commented on a diff in pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1195822189


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   Different compiler version is potentially concerning, but the question is if there is enough risk to justify another hour-long build. Probably not?
   
   What about nightly packages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #35523: GH-35392: [R][CI] Bump the R versions we test to include 4.3

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35523:
URL: https://github.com/apache/arrow/pull/35523#issuecomment-1710623206

   Revision: 9613da8cbaf7eb0bb898a2051308654b67093b38
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-7a4117a641](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7a4117a641)
   
   |Task|Status|
   |----|------|
   |conda-linux-aarch64-cpu-r41|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-linux-aarch64-cpu-r41)](https://github.com/ursacomputing/crossbow/tree/actions-7a4117a641-azure-conda-linux-aarch64-cpu-r41)|
   |conda-linux-aarch64-cpu-r42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-linux-aarch64-cpu-r42)](https://github.com/ursacomputing/crossbow/runs/16593489340)|
   |conda-linux-x64-cpu-r41|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-linux-x64-cpu-r41)](https://github.com/ursacomputing/crossbow/runs/16593505091)|
   |conda-linux-x64-cpu-r42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-linux-x64-cpu-r42)](https://github.com/ursacomputing/crossbow/runs/16593485149)|
   |conda-osx-arm64-cpu-r41|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-osx-arm64-cpu-r41)](https://github.com/ursacomputing/crossbow/tree/actions-7a4117a641-azure-conda-osx-arm64-cpu-r41)|
   |conda-osx-arm64-cpu-r42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-osx-arm64-cpu-r42)](https://github.com/ursacomputing/crossbow/runs/16593527324)|
   |conda-osx-x64-cpu-r41|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-osx-x64-cpu-r41)](https://github.com/ursacomputing/crossbow/runs/16593535182)|
   |conda-osx-x64-cpu-r42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-osx-x64-cpu-r42)](https://github.com/ursacomputing/crossbow/runs/16593537868)|
   |conda-win-x64-cpu-r41|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-conda-win-x64-cpu-r41)](https://github.com/ursacomputing/crossbow/runs/16593491073)|
   |homebrew-r-autobrew|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-homebrew-r-autobrew)](https://github.com/ursacomputing/crossbow/actions/runs/6113636749/job/16593524213)|
   |homebrew-r-brew|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-homebrew-r-brew)](https://github.com/ursacomputing/crossbow/actions/runs/6113623367/job/16593481369)|
   |r-binary-packages|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-r-binary-packages)](https://github.com/ursacomputing/crossbow/actions/runs/6113635547/job/16593541541)|
   |test-fedora-r-clang-sanitizer|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-fedora-r-clang-sanitizer)](https://github.com/ursacomputing/crossbow/runs/16593493105)|
   |test-r-arrow-backwards-compatibility|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-arrow-backwards-compatibility)](https://github.com/ursacomputing/crossbow/actions/runs/6113641902/job/16593538728)|
   |test-r-depsource-bundled|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-depsource-bundled)](https://github.com/ursacomputing/crossbow/runs/16593528557)|
   |test-r-depsource-system|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-depsource-system)](https://github.com/ursacomputing/crossbow/actions/runs/6113641068/job/16593536519)|
   |test-r-dev-duckdb|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-dev-duckdb)](https://github.com/ursacomputing/crossbow/actions/runs/6113639133/job/16593530617)|
   |test-r-devdocs|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-devdocs)](https://github.com/ursacomputing/crossbow/actions/runs/6113632511/job/16593510971)|
   |test-r-gcc-11|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-gcc-11)](https://github.com/ursacomputing/crossbow/actions/runs/6113629912/job/16593501776)|
   |test-r-gcc-12|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-gcc-12)](https://github.com/ursacomputing/crossbow/actions/runs/6113627277/job/16593493393)|
   |test-r-install-local|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions/runs/6113633044/job/16593512309)|
   |test-r-install-local-minsizerel|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-install-local-minsizerel)](https://github.com/ursacomputing/crossbow/actions/runs/6113627705/job/16593495919)|
   |test-r-library-r-base-latest|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-library-r-base-latest)](https://github.com/ursacomputing/crossbow/runs/16593503568)|
   |test-r-linux-as-cran|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions/runs/6113634785/job/16593517923)|
   |test-r-linux-rchk|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-linux-rchk)](https://github.com/ursacomputing/crossbow/actions/runs/6113639656/job/16593532124)|
   |test-r-linux-valgrind|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-linux-valgrind)](https://github.com/ursacomputing/crossbow/runs/16593497925)|
   |test-r-minimal-build|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-minimal-build)](https://github.com/ursacomputing/crossbow/runs/16593536456)|
   |test-r-offline-maximal|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-offline-maximal)](https://github.com/ursacomputing/crossbow/actions/runs/6113624575/job/16593484378)|
   |test-r-offline-minimal|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-offline-minimal)](https://github.com/ursacomputing/crossbow/runs/16593511404)|
   |test-r-rhub-debian-gcc-devel-lto-latest|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-rhub-debian-gcc-devel-lto-latest)](https://github.com/ursacomputing/crossbow/runs/16593515237)|
   |test-r-rhub-debian-gcc-release-custom-ccache|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-rhub-debian-gcc-release-custom-ccache)](https://github.com/ursacomputing/crossbow/runs/16593516890)|
   |test-r-rhub-ubuntu-gcc-release-latest|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-rhub-ubuntu-gcc-release-latest)](https://github.com/ursacomputing/crossbow/runs/16593522771)|
   |test-r-rstudio-r-base-4.3-centos7-devtoolset-8|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-rstudio-r-base-4.3-centos7-devtoolset-8)](https://github.com/ursacomputing/crossbow/runs/16593508145)|
   |test-r-rstudio-r-base-4.3-focal|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-rstudio-r-base-4.3-focal)](https://github.com/ursacomputing/crossbow/runs/16593542030)|
   |test-r-rstudio-r-base-4.3-opensuse153|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-r-rstudio-r-base-4.3-opensuse153)](https://github.com/ursacomputing/crossbow/runs/16593519453)|
   |test-r-ubuntu-22.04|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-ubuntu-22.04)](https://github.com/ursacomputing/crossbow/actions/runs/6113638628/job/16593529406)|
   |test-r-versions|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-7a4117a641-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions/runs/6113628882/job/16593499531)|
   |test-ubuntu-r-sanitizer|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-7a4117a641-azure-test-ubuntu-r-sanitizer)](https://github.com/ursacomputing/crossbow/runs/16593510250)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1354353766


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   Unsure what's sensible re Windows. I see that [R 4.2 onwards drops support for 32-bit builds on Windows](https://blog.r-project.org/2021/12/07/upcoming-changes-in-r-4.2-on-windows/).  Should we perhaps wait a bit longer until we're no longer supporting older R versions, or is this too cautious? Keen to get your thoughts here @paleolimbot 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-35392: [R][CI] Bump the R versions we test to include 4.3 [arrow]

Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #35523:
URL: https://github.com/apache/arrow/pull/35523#discussion_r1355403374


##########
.github/workflows/r.yml:
##########
@@ -234,8 +234,8 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        - { rtools: 42, rversion: "4.2" }

Review Comment:
   RSPM (technically, PPPM today) will need the libarrow binaries to build for those older R versions, so it's not a solution to the problem, it's actually a reason to keep building the 32-bit packages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org