[GitHub] [dubbo-samples] kylixs commented on a change in pull request #265: Improve api case

[GitBox <gi...@apache.org>]

kylixs commented on a change in pull request #265:
URL: https://github.com/apache/dubbo-samples/pull/265#discussion_r558257461



##########
File path: dubbo-samples-api/pom.xml
##########
@@ -27,184 +27,62 @@
     <artifactId>dubbo-samples-api</artifactId>
 
     <properties>
-        <source.level>1.8</source.level>
-        <target.level>1.8</target.level>
         <dubbo.version>2.7.7</dubbo.version>
         <junit.version>4.12</junit.version>
-        <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
-        <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
-        <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
-        <maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
-        <image.name>${project.artifactId}:${dubbo.version}</image.name>
-        <java-image.name>openjdk:8</java-image.name>
-        <dubbo.port>20880</dubbo.port>
-        <zookeeper.port>2181</zookeeper.port>
-        <main-class>org.apache.dubbo.samples.provider.Application</main-class>
     </properties>
 
+    <dependencyManagement>
+        <dependencies>
+            <dependency>
+                <groupId>org.apache.dubbo</groupId>
+                <artifactId>dubbo</artifactId>

Review comment:
       1.添加spring-framework-bom
   2.用dubbo-bom 管理dubbo的组件版本
   请参考文档: https://github.com/apache/dubbo-samples/blob/master/test/convert-case.md#maven%E9%85%8D%E7%BD%AE%E4%BC%98%E5%8C%96




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org