You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/05/18 21:32:05 UTC
Review Request 47553: GEODE-1397: Rename HelpCommandsJUnitTest to
...IntegrationTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47553/
-----------------------------------------------------------
Review request for geode, Jinmei Liao and Kirk Lund.
Repository: geode
Description
-------
GEODE-1397: Fixing testOfflineHelp
GEODE-1397: Adding new help text from create async-event-queue
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java 1d81d2e0dfe1600fa500a6c2a7f320790e6aa836
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties a9dc64cbb5d0162aaa0927f3faec98632ced1c33
Diff: https://reviews.apache.org/r/47553/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 47553: GEODE-1397: Rename HelpCommandsJUnitTest to
...IntegrationTest
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47553/#review134069
-----------------------------------------------------------
Ship it!
geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java (line 80)
<https://reviews.apache.org/r/47553/#comment198700>
[Not an issue] Another option is:
getClass().getResourceAsStream(...)
- Kirk Lund
On May 18, 2016, 9:32 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47553/
> -----------------------------------------------------------
>
> (Updated May 18, 2016, 9:32 p.m.)
>
>
> Review request for geode, Jinmei Liao and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1397: Fixing testOfflineHelp
>
>
> GEODE-1397: Adding new help text from create async-event-queue
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java 1d81d2e0dfe1600fa500a6c2a7f320790e6aa836
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties a9dc64cbb5d0162aaa0927f3faec98632ced1c33
>
> Diff: https://reviews.apache.org/r/47553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 47553: GEODE-1397: Rename HelpCommandsJUnitTest to
...IntegrationTest
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47553/#review133843
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On May 18, 2016, 9:32 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47553/
> -----------------------------------------------------------
>
> (Updated May 18, 2016, 9:32 p.m.)
>
>
> Review request for geode, Jinmei Liao and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1397: Fixing testOfflineHelp
>
>
> GEODE-1397: Adding new help text from create async-event-queue
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HelpCommandsJUnitTest.java 1d81d2e0dfe1600fa500a6c2a7f320790e6aa836
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/cli/commands/golden-help-offline.properties a9dc64cbb5d0162aaa0927f3faec98632ced1c33
>
> Diff: https://reviews.apache.org/r/47553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>