You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/31 16:55:24 UTC
[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull
request #4455: Fix num entries scanned in filter for MultiValue scanner
sunithabeeram commented on a change in pull request #4455: Fix num entries scanned in filter for MultiValue scanner
URL: https://github.com/apache/incubator-pinot/pull/4455#discussion_r309328027
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/MVScanDocIdIterator.java
##########
@@ -80,9 +81,11 @@ public boolean isMatch(int docId) {
return false;
}
valueIterator.skipTo(docId);
- _numEntriesScanned++;
int length = valueIterator.nextIntVal(intArray);
- return evaluator.applyMV(intArray, length);
+ MutableInt numEntriesScannedInEvaluator = new MutableInt(0);
+ boolean ret = evaluator.applyMV(intArray, length, numEntriesScannedInEvaluator);
+ _numEntriesScanned += numEntriesScannedInEvaluator.toInteger();
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org