You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by brosander <gi...@git.apache.org> on 2016/12/02 20:15:47 UTC
[GitHub] nifi pull request #1292: NIFI-3132 - Using cygpath and quoting paths correct...
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1292
NIFI-3132 - Using cygpath and quoting paths correctly in sh scripts w\u2026
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] - N/A - Have you written or updated unit tests to verify your changes?
- [x] - N/A - If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] - N/A - If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [x] - N/A - If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [x] - N/A - If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] - N/A - Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
\u2026hen run in cygwin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brosander/nifi NIFI-3132
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1292
----
commit 3eef9a29126effdde4b49d609865877e7718376a
Author: Bryan Rosander <br...@apache.org>
Date: 2016-12-02T19:43:22Z
NIFI-3132 - Using cygpath and quoting paths correctly in sh scripts when run in cygwin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1292: NIFI-3132 - Using cygpath and quoting paths correctly in s...
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on the issue:
https://github.com/apache/nifi/pull/1292
+1
Built under Windows 7, and with a base Cygwin install, was able to run NiFi from outside of the bin dir:
`/cygdrive/c/Users/Jeff/nifi-dev/nifi/nifi-assembly/target/nifi-1.2.0-SNAPSHOT-bin/nifi-1.2.0-SNAPSHOT
$ bin/nifi.sh run`
Verified that the log directory location was correct:
`-Dorg.apache.nifi.bootstrap.config.log.dir=C:\Users\Jeff\nifi-dev\nifi\nifi-assembly\target\nifi-1.2.0-SNAPSHOT-bin\nifi-1.2.0-SNAPSHOT\logs`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1292: NIFI-3132 - Using cygpath and quoting paths correct...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1292: NIFI-3132 - Using cygpath and quoting paths correctly in s...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1292
Merging after review by @jtstorck
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---