You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/29 23:27:08 UTC

[GitHub] [airflow] potiuk opened a new pull request, #27371: Extract tests to composite actions

potiuk opened a new pull request, #27371:
URL: https://github.com/apache/airflow/pull/27371

   Extract tests to composite actions in CI
   
   This change is a follow-up after #27369 - it extracts test steps to
   a composite action.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #27371: Extract tests to composite actions

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27371:
URL: https://github.com/apache/airflow/pull/27371#issuecomment-1296019807

   Should be merged after #27369 and #27368 -> so only last commit counts. 
   
   But this one makes extracts common "test" steps into composite action.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #27371: Extract tests to composite actions

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27371:
URL: https://github.com/apache/airflow/pull/27371


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #27371: Extract tests to composite actions

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27371:
URL: https://github.com/apache/airflow/pull/27371#issuecomment-1296322136

   I think this one is ready to go. It has test execution extracted to a separate composite actiions and overall the ci.yml is way simpler and straightforward with - a lot less code duplication.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #27371: Extract tests to composite actions

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27371:
URL: https://github.com/apache/airflow/pull/27371#issuecomment-1296323245

   Also - I run a build in my own fork -running PR from 2nd fork :) to see that it works fine also in this scenario: https://github.com/potiuk/airflow/actions/runs/3356444919/jobs/5561698534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org