You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Emmanuel Bourg (JIRA)" <ji...@apache.org> on 2010/10/19 01:42:26 UTC
[jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922357#action_12922357 ]
Emmanuel Bourg commented on QPID-2498:
--------------------------------------
I updated the patch, it's now available as a branch on Github. Please let me know if this format is not suitable.
http://github.com/ebourg/qpid/tree/mina-upgrade
http://github.com/ebourg/qpid/commit/7c4f9e87788261c36ed804f3a13e8ae0c1891205
> Upgrade Mina to 1.1.7
> ---------------------
>
> Key: QPID-2498
> URL: https://issues.apache.org/jira/browse/QPID-2498
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client
> Affects Versions: 0.6
> Reporter: Emmanuel Bourg
> Assignee: Martin Ritchie
> Fix For: 0.7
>
> Attachments: mina-update.patch
>
>
> Upgrading Mina to 1.1.7 would allow the removal of backport-util-concurrent.jar from the dependencies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 19/10/2010 15:26, Rajith Attapattu a écrit :
> IIRC you also had a patch for removing MINA ByteBuffers from the
> client/common code.
> If you don't mind could you please post the JIRA number and the patch
> (attached to JIRA with license box checked).
I started working on this but the patch is incomplete. I didn't address
the auto growing buffer for the JMS messages. I got lost in the messages
life cycle and I didn't have enough tests to ensure nothing was getting
broken.
The patch is attached to QPID-2627. I have already filed a CLA with the
ASF, so feel free to use my contributions :)
Emmanuel Bourg
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Posted by Rajith Attapattu <ra...@gmail.com>.
Emmanuel,
IIRC you also had a patch for removing MINA ByteBuffers from the
client/common code.
If you don't mind could you please post the JIRA number and the patch
(attached to JIRA with license box checked).
One of my goals for the next release is to get rid of MINA deps from the
client and common code.
If you have already done some work I would like to use that as a base.
Andrew have you done any work in this area at all ? I'd like to coordinate
with you on this.
Regards,
Rajith
On Tue, Oct 19, 2010 at 9:10 AM, Rajith Attapattu <ra...@gmail.com>wrote:
>
>
> On Tue, Oct 19, 2010 at 6:04 AM, Emmanuel Bourg <eb...@apache.org> wrote:
>
>> Thank you for taking care of this Andrew. Do you know if it will make it
>> into the 0.8 release?
>>
>> I attached a diff to JIRA.
>>
>>
> All though I would like to see this in the 0.8 release, I think given the
> timelines it may not be possible.
> It's a shame as you have worked on this for a while now. But I think you
> agree that stability is very important here.
>
> However we are planning to have more frequent releases. So I hope that you
> don't have to wait for long for this to be included.
> Perhaps we should have another release in Feb/March time frame.
>
> Since Andrew is already working on the MINA stuff, it's best to get
> everything into trunk along with his work.
>
> Regards,
>
> Rajith.
>
> P.S Emmanuel, I really appreciate the work you have done. This is one item
> that I wanted to tackle for a while.
>
>
>> Emmanuel Bourg
>>
>>
>> Le 19/10/2010 09:18, Andrew Kennedy a écrit :
>>
>>
>> Thanks for that. I hadn't seen some of the changes you made there, so I
>>> have added them to the branch code I am working on, which contains an
>>> independently arrived at MINA 1.1.7 upgrade. (see QPID-2811 for the
>>> rest, not yet completed.)
>>>
>>> I'll credit you for the upgrade patch when I commit my changes to TRUNK,
>>> since they are identical and you implemented it first. However, I think
>>> you need to attach a physical patch file to the JIRA, in order to
>>> fulfill ASF copyright requirements.
>>>
>>> Andrew.
>>>
>>
>>
>>
>
>
> --
> Regards,
>
> Rajith Attapattu
> Red Hat
> http://rajith.2rlabs.com/
>
--
Regards,
Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Posted by Rajith Attapattu <ra...@gmail.com>.
On Tue, Oct 19, 2010 at 6:04 AM, Emmanuel Bourg <eb...@apache.org> wrote:
> Thank you for taking care of this Andrew. Do you know if it will make it
> into the 0.8 release?
>
> I attached a diff to JIRA.
>
>
All though I would like to see this in the 0.8 release, I think given the
timelines it may not be possible.
It's a shame as you have worked on this for a while now. But I think you
agree that stability is very important here.
However we are planning to have more frequent releases. So I hope that you
don't have to wait for long for this to be included.
Perhaps we should have another release in Feb/March time frame.
Since Andrew is already working on the MINA stuff, it's best to get
everything into trunk along with his work.
Regards,
Rajith.
P.S Emmanuel, I really appreciate the work you have done. This is one item
that I wanted to tackle for a while.
> Emmanuel Bourg
>
>
> Le 19/10/2010 09:18, Andrew Kennedy a écrit :
>
>
> Thanks for that. I hadn't seen some of the changes you made there, so I
>> have added them to the branch code I am working on, which contains an
>> independently arrived at MINA 1.1.7 upgrade. (see QPID-2811 for the
>> rest, not yet completed.)
>>
>> I'll credit you for the upgrade patch when I commit my changes to TRUNK,
>> since they are identical and you implemented it first. However, I think
>> you need to attach a physical patch file to the JIRA, in order to
>> fulfill ASF copyright requirements.
>>
>> Andrew.
>>
>
>
>
--
Regards,
Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Posted by Emmanuel Bourg <eb...@apache.org>.
Thank you for taking care of this Andrew. Do you know if it will make it
into the 0.8 release?
I attached a diff to JIRA.
Emmanuel Bourg
Le 19/10/2010 09:18, Andrew Kennedy a écrit :
> Thanks for that. I hadn't seen some of the changes you made there, so I
> have added them to the branch code I am working on, which contains an
> independently arrived at MINA 1.1.7 upgrade. (see QPID-2811 for the
> rest, not yet completed.)
>
> I'll credit you for the upgrade patch when I commit my changes to TRUNK,
> since they are identical and you implemented it first. However, I think
> you need to attach a physical patch file to the JIRA, in order to
> fulfill ASF copyright requirements.
>
> Andrew.
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Posted by Andrew Kennedy <an...@gmail.com>.
Emmanuel,
Thanks for that. I hadn't seen some of the changes you made there, so
I have added them to the branch code I am working on, which contains
an independently arrived at MINA 1.1.7 upgrade. (see QPID-2811 for
the rest, not yet completed.)
I'll credit you for the upgrade patch when I commit my changes to
TRUNK, since they are identical and you implemented it first.
However, I think you need to attach a physical patch file to the
JIRA, in order to fulfill ASF copyright requirements.
Andrew.
--
-- andrew d kennedy ? do not fold, bend, spindle, or mutilate ;
-- http://grkvlt.blogspot.com/ ? edinburgh : +44 7941 197 134 ;
On 19 Oct 2010, at 00:42, Emmanuel Bourg (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/QPID-2498?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=12922357#action_12922357 ]
>
> Emmanuel Bourg commented on QPID-2498:
> --------------------------------------
>
> I updated the patch, it's now available as a branch on Github.
> Please let me know if this format is not suitable.
>
> http://github.com/ebourg/qpid/tree/mina-upgrade
>
> http://github.com/ebourg/qpid/commit/
> 7c4f9e87788261c36ed804f3a13e8ae0c1891205
>
>
>> Upgrade Mina to 1.1.7
>> ---------------------
>>
>> Key: QPID-2498
>> URL: https://issues.apache.org/jira/browse/QPID-2498
>> Project: Qpid
>> Issue Type: Improvement
>> Components: Java Broker, Java Client
>> Affects Versions: 0.6
>> Reporter: Emmanuel Bourg
>> Assignee: Martin Ritchie
>> Fix For: 0.7
>>
>> Attachments: mina-update.patch
>>
>>
>> Upgrading Mina to 1.1.7 would allow the removal of backport-util-
>> concurrent.jar from the dependencies.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org