You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/04 18:21:48 UTC

[GitHub] [incubator-superset] etr2460 opened a new pull request #9728: chore: update README screenshots

etr2460 opened a new pull request #9728:
URL: https://github.com/apache/incubator-superset/pull/9728


   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [x] Documentation
   
   ### SUMMARY
   The current screenshots are rather out of date, I've updated the first 3 but couldn't update the other 2 because the deck.gl charts don't render properly for me. Maybe someone else could pick that up for me?
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   
   ### TEST PLAN
   CI
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   to: @mistercrunch 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #9728: chore: update README screenshots

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #9728:
URL: https://github.com/apache/incubator-superset/pull/9728#issuecomment-624276116


   That's not actually where they can be viewed because the README pulls from the master images. But i'll see it in master after merging now anyway


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #9728: chore: update README screenshots

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #9728:
URL: https://github.com/apache/incubator-superset/pull/9728#issuecomment-623883199


   @etr2460 thanks for taking the time. LGTM. Can be viewed here https://github.com/etr2460/incubator-superset/tree/erik-ritter--update-screenshots
   
   We're looking to update the screenshots further soon, throwing in a high quality animated gif, and finding some ways to get more density with tiles.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org