You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "j143 (via GitHub)" <gi...@apache.org> on 2023/04/07 16:22:18 UTC
[GitHub] [systemds] j143 opened a new pull request, #1803: [SYSTEMDS-2102] Vectorize gradients for Factorization Machines function
j143 opened a new pull request, #1803:
URL: https://github.com/apache/systemds/pull/1803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1803: [SYSTEMDS-2102] Vectorize gradients for Factorization Machines function
Posted by "j143 (via GitHub)" <gi...@apache.org>.
j143 commented on PR #1803:
URL: https://github.com/apache/systemds/pull/1803#issuecomment-1521858443
Hi @Baunsgaard - thanks for review.
I believe the vectorization I made is incorrect, especially output dimensions.
I will keep this in draft for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1803: [SYSTEMDS-2102] Vectorize gradients for Factorization Machines function
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #1803:
URL: https://github.com/apache/systemds/pull/1803#issuecomment-1521782225
LGTM
but remove the commented code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1803: [SYSTEMDS-2102] Vectorize gradients for Factorization Machines function
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #1803:
URL: https://github.com/apache/systemds/pull/1803#issuecomment-1522319631
> Hi @Baunsgaard - thanks for review.
>
> I believe the vectorization I made is incorrect, especially output dimensions. I will keep this in draft for a while.
aww sad, it looked good at a surface glance, maybe we do not have enough tests ?
or is it that the NN is only in the Application tests again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1803: [SYSTEMDS-2102] Vectorize gradients for Factorization Machines function
Posted by "j143 (via GitHub)" <gi...@apache.org>.
j143 commented on PR #1803:
URL: https://github.com/apache/systemds/pull/1803#issuecomment-1528598722
We verify the with gradients at the moment. but, we need to verify against R implementation once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1803: [SYSTEMDS-2102] Vectorize gradients for Factorization Machines function
Posted by "j143 (via GitHub)" <gi...@apache.org>.
j143 commented on PR #1803:
URL: https://github.com/apache/systemds/pull/1803#issuecomment-1500456415
the code doesn't seem to be correct:
-- old g_V2 --
0.000 0.000
0.000 -0.001
0.000 -0.000
0.000 -0.002
0.000 0.000
0.000 -0.001
0.000 -0.014
-- g_V2 --
0.000 -0.017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org