[jira] [Commented] (MAPREDUCE-5819) Binary token merge should be done once in TokenCache#obtainTokensForNamenodesInternal()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628283#comment-14628283 ] 

Hadoop QA commented on MAPREDUCE-5819:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | patch |   0m  1s | The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. |
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12638362/mapreduce-5819-v1.txt |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / edcaae4 |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5888/console |


This message was automatically generated.

> Binary token merge should be done once in TokenCache#obtainTokensForNamenodesInternal()
> ---------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5819
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5819
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: security
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: mapreduce-5819-v1.txt
>
>
> Currently mergeBinaryTokens() is called by every invocation of obtainTokensForNamenodesInternal(FileSystem, Credentials, Configuration) in the loop of obtainTokensForNamenodesInternal(Credentials, Path[], Configuration).
> This can be simplified such that mergeBinaryTokens() is called only once in obtainTokensForNamenodesInternal(Credentials, Path[], Configuration).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)