DO NOT REPLY [Bug 13503] New: - JspParseEventListener.java outputs broken setContentType(...) row

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13503>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13503

JspParseEventListener.java outputs broken setContentType(...) row

           Summary: JspParseEventListener.java outputs broken
                    setContentType(...) row
           Product: Tomcat 4
           Version: 4.0.4 Final
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Other
         Component: Jasper
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: vesalainen@mermit.fi


The version is 4.0.6 as opposed to 4.0.4 Final (4.0.6 was not available in the  
Version list):  
  
>From org.apache.jasper.compiler.JspParseEventListener.java: 
 
162:      defaultType = "text/html;"; 
163:      defaultCharset = "ISO-8859-1"; 
... 
362: // Per errata_a, determine the default output content type  
363:        if (servletContentType == null) {  
364:            servletContentType = defaultType +  
365:                 ((pageEncoding == null)? defaultCharset: pageEncoding);  
366:        }  
367:        writer.println("response.setContentType("  
378:                           + writer.quoteString(servletContentType)  
369:                           + ");");  
  
This produces the following line of code to the compiled JSP .java file 
  
response.setContentType("text/html;ISO-8859-1");  
  
I propose that this is not correct, but should instead be:  
  
response.setContentType("text/html;charset=ISO-8859-1"); 
 
The fix is to change row 364 to be: 
 
364:            servletContentType = defaultType + "charset=" +

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>