[GitHub] [druid] FrankChen021 commented on a diff in pull request #12473: Enable usage of multiple base task directories

[GitBox <gi...@apache.org>]

FrankChen021 commented on code in PR #12473:
URL: https://github.com/apache/druid/pull/12473#discussion_r857072565


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java:
##########
@@ -175,6 +211,14 @@ public TaskConfig(
     }
     log.debug("Batch processing mode:[%s]", this.batchProcessingMode);
     this.storeEmptyColumns = storeEmptyColumns == null ? DEFAULT_STORE_EMPTY_COLUMNS : storeEmptyColumns;
+
+    if (baseTaskDirLocations == null || baseTaskDirLocations.size() == 0) {
+      File baseTaskFile = new File(defaultDir(baseTaskDir, "persistent/task"));

Review Comment:
   the `baseTaskDir` configuration now is meaningful when the new `baseTaskDirLocations` is not set. For the long term evolution, should the `baseTaskDir` be marked as deprecated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org