You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/10/13 18:48:36 UTC
Review Request 26649: Constant folding should happen before predicate
pushdown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26649/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-8358
https://issues.apache.org/jira/browse/HIVE-8358
Repository: hive
Description
-------
Constant folding should happen before predicate pushdown
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 1631285
trunk/ql/src/test/results/clientpositive/annotate_stats_part.q.out 1631285
trunk/ql/src/test/results/clientpositive/bucket3.q.out 1631285
trunk/ql/src/test/results/clientpositive/columnstats_partlvl.q.out 1631285
trunk/ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out 1631285
trunk/ql/src/test/results/clientpositive/constprog_dp.q.out 1631285
trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out 1631285
trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out 1631285
trunk/ql/src/test/results/clientpositive/input23.q.out 1631285
trunk/ql/src/test/results/clientpositive/input25.q.out 1631285
trunk/ql/src/test/results/clientpositive/input26.q.out 1631285
trunk/ql/src/test/results/clientpositive/input42.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part0.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part1.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part2.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part3.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part5.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part7.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part8.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part9.q.out 1631285
trunk/ql/src/test/results/clientpositive/limit_partition_metadataonly.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_12.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_13.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_2.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_4.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_5.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_9.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_query_multiskew_3.q.out 1631285
trunk/ql/src/test/results/clientpositive/merge_dynamic_partition.q.out 1631285
trunk/ql/src/test/results/clientpositive/nonmr_fetch.q.out 1631285
trunk/ql/src/test/results/clientpositive/nonmr_fetch_threshold.q.out 1631285
trunk/ql/src/test/results/clientpositive/pcr.q.out 1631285
trunk/ql/src/test/results/clientpositive/ppd2.q.out 1631285
trunk/ql/src/test/results/clientpositive/ppd_udf_case.q.out 1631285
trunk/ql/src/test/results/clientpositive/ppd_union_view.q.out 1631285
trunk/ql/src/test/results/clientpositive/quotedid_partition.q.out 1631285
trunk/ql/src/test/results/clientpositive/rand_partitionpruner2.q.out 1631285
trunk/ql/src/test/results/clientpositive/rand_partitionpruner3.q.out 1631285
trunk/ql/src/test/results/clientpositive/sample1.q.out 1631285
trunk/ql/src/test/results/clientpositive/sample8.q.out 1631285
trunk/ql/src/test/results/clientpositive/smb_mapjoin9.q.out 1631285
trunk/ql/src/test/results/clientpositive/smb_mapjoin_10.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/bucket3.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/dynamic_partition_pruning_2.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/sample1.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/transform_ppr2.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 1631285
trunk/ql/src/test/results/clientpositive/transform_ppr2.q.out 1631285
trunk/ql/src/test/results/clientpositive/truncate_column_list_bucket.q.out 1631285
trunk/ql/src/test/results/clientpositive/union_ppr.q.out 1631285
trunk/ql/src/test/results/clientpositive/union_remove_25.q.out 1631285
trunk/ql/src/test/results/clientpositive/union_view.q.out 1631285
trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1631285
trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1631285
Diff: https://reviews.apache.org/r/26649/diff/
Testing
-------
Existing test cases.
Thanks,
Ashutosh Chauhan
Re: Review Request 26649: Constant folding should happen before
predicate pushdown
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26649/
-----------------------------------------------------------
(Updated Oct. 13, 2014, 4:48 p.m.)
Review request for hive.
Bugs: HIVE-8358
https://issues.apache.org/jira/browse/HIVE-8358
Repository: hive
Description
-------
Constant folding should happen before predicate pushdown
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 1631285
trunk/ql/src/test/results/clientpositive/annotate_stats_part.q.out 1631285
trunk/ql/src/test/results/clientpositive/bucket3.q.out 1631285
trunk/ql/src/test/results/clientpositive/columnstats_partlvl.q.out 1631285
trunk/ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out 1631285
trunk/ql/src/test/results/clientpositive/constprog_dp.q.out 1631285
trunk/ql/src/test/results/clientpositive/index_auto_unused.q.out 1631285
trunk/ql/src/test/results/clientpositive/index_stale_partitioned.q.out 1631285
trunk/ql/src/test/results/clientpositive/input23.q.out 1631285
trunk/ql/src/test/results/clientpositive/input25.q.out 1631285
trunk/ql/src/test/results/clientpositive/input26.q.out 1631285
trunk/ql/src/test/results/clientpositive/input42.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part0.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part1.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part2.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part3.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part5.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part7.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part8.q.out 1631285
trunk/ql/src/test/results/clientpositive/input_part9.q.out 1631285
trunk/ql/src/test/results/clientpositive/limit_partition_metadataonly.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_12.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_13.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_2.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_4.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_5.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_dml_9.q.out 1631285
trunk/ql/src/test/results/clientpositive/list_bucket_query_multiskew_3.q.out 1631285
trunk/ql/src/test/results/clientpositive/merge_dynamic_partition.q.out 1631285
trunk/ql/src/test/results/clientpositive/nonmr_fetch.q.out 1631285
trunk/ql/src/test/results/clientpositive/nonmr_fetch_threshold.q.out 1631285
trunk/ql/src/test/results/clientpositive/pcr.q.out 1631285
trunk/ql/src/test/results/clientpositive/ppd2.q.out 1631285
trunk/ql/src/test/results/clientpositive/ppd_udf_case.q.out 1631285
trunk/ql/src/test/results/clientpositive/ppd_union_view.q.out 1631285
trunk/ql/src/test/results/clientpositive/quotedid_partition.q.out 1631285
trunk/ql/src/test/results/clientpositive/rand_partitionpruner2.q.out 1631285
trunk/ql/src/test/results/clientpositive/rand_partitionpruner3.q.out 1631285
trunk/ql/src/test/results/clientpositive/sample1.q.out 1631285
trunk/ql/src/test/results/clientpositive/sample8.q.out 1631285
trunk/ql/src/test/results/clientpositive/smb_mapjoin9.q.out 1631285
trunk/ql/src/test/results/clientpositive/smb_mapjoin_10.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/bucket3.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/dynamic_partition_pruning_2.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/sample1.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/transform_ppr2.q.out 1631285
trunk/ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 1631285
trunk/ql/src/test/results/clientpositive/transform_ppr2.q.out 1631285
trunk/ql/src/test/results/clientpositive/truncate_column_list_bucket.q.out 1631285
trunk/ql/src/test/results/clientpositive/union_ppr.q.out 1631285
trunk/ql/src/test/results/clientpositive/union_remove_25.q.out 1631285
trunk/ql/src/test/results/clientpositive/union_view.q.out 1631285
trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1631285
trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1631285
Diff: https://reviews.apache.org/r/26649/diff/
Testing
-------
Existing test cases.
Thanks,
Ashutosh Chauhan