You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Chad Dombrova (Jira)" <ji...@apache.org> on 2020/01/08 02:04:00 UTC

[jira] [Commented] (BEAM-9064) Add pytype to lint checks

    [ https://issues.apache.org/jira/browse/BEAM-9064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010258#comment-17010258 ] 

Chad Dombrova commented on BEAM-9064:
-------------------------------------

I am _very_ reticent to implement this.  I haven't used pytype, but my experience working with mypy over the past few years, and following various issues and peps related to it and typing in general,  has taught me there's still a lot of room for interpretation and thus variation between type checkers.  As a user, it can be quite challenging to solve certain typing issues, and I would not be the least bit surprised to find that certain problems cannot be solved in a way that satisfies both linters, at least not without some seriously ugly workarounds.  We're already asking for our contributors to gain a whole new area of expertise in order to get their PRs merged – one with a fairly steep learning curve –  I wouldn't want to burden them with an additional linter with its own idiosyncrasies.  

 

> Add pytype to lint checks
> -------------------------
>
>                 Key: BEAM-9064
>                 URL: https://issues.apache.org/jira/browse/BEAM-9064
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core, testing
>            Reporter: Udi Meiri
>            Assignee: Udi Meiri
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> [~chadrik]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)