[GitHub] [incubator-iceberg] danielcweeks commented on a change in pull request #338: Add mapping to Iceberg for external name-based schemas

[GitBox <gi...@apache.org>]

danielcweeks commented on a change in pull request #338: Add mapping to Iceberg for external name-based schemas
URL: https://github.com/apache/incubator-iceberg/pull/338#discussion_r309432140
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/TableProperties.java
 ##########
 @@ -91,4 +91,6 @@ private TableProperties() {}
 
   public static final String DEFAULT_WRITE_METRICS_MODE = "write.metadata.metrics.default";
   public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = "truncate(16)";
+
+  public static final String DEFAULT_NAME_MAPPING = "schema.name-mapping.default";
 
 Review comment:
   We're calling this default, but it's not really a default, right?  Shouldn't this just be `schema.name-mapping`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org