You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by dk...@apache.org on 2008/11/07 22:29:32 UTC

svn commit: r712275 - in /cxf/branches/2.1.x-fixes: ./ api/src/main/java/org/apache/cxf/ rt/core/src/main/java/org/apache/cxf/bus/ rt/core/src/main/java/org/apache/cxf/bus/spring/ rt/core/src/main/java/org/apache/cxf/buslifecycle/ rt/core/src/main/reso...

Author: dkulp
Date: Fri Nov  7 13:29:32 2008
New Revision: 712275

URL: http://svn.apache.org/viewvc?rev=712275&view=rev
Log:
Merged revisions 712272 via svnmerge from 
https://svn.apache.org/repos/asf/cxf/trunk

........
  r712272 | dkulp | 2008-11-07 16:27:54 -0500 (Fri, 07 Nov 2008) | 2 lines
  
  For spring applications and such, make sure the bus lifecycle listeners are called.
........

Added:
    cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/spring/BusApplicationListener.java
      - copied unchanged from r712272, cxf/trunk/rt/core/src/main/java/org/apache/cxf/bus/spring/BusApplicationListener.java
    cxf/branches/2.1.x-fixes/systests/src/test/java/org/apache/cxf/systest/wsdl/CrossSchemaImportsTests.java
      - copied unchanged from r712272, cxf/trunk/systests/src/test/java/org/apache/cxf/systest/wsdl/CrossSchemaImportsTests.java
    cxf/branches/2.1.x-fixes/systests/src/test/java/org/apache/cxf/systest/wsdl/LifeCycleListenerTester.java
      - copied unchanged from r712272, cxf/trunk/systests/src/test/java/org/apache/cxf/systest/wsdl/LifeCycleListenerTester.java
Removed:
    cxf/branches/2.1.x-fixes/systests/src/test/java/org/apache/cxf/systest/wsdl/TestCrossSchemaImports.java
Modified:
    cxf/branches/2.1.x-fixes/   (props changed)
    cxf/branches/2.1.x-fixes/api/src/main/java/org/apache/cxf/BusFactory.java
    cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/CXFBusFactory.java
    cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/spring/SpringBusFactory.java
    cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/buslifecycle/CXFBusLifeCycleManager.java
    cxf/branches/2.1.x-fixes/rt/core/src/main/resources/META-INF/cxf/cxf.xml
    cxf/branches/2.1.x-fixes/rt/core/src/test/java/org/apache/cxf/bus/spring/SpringBusFactoryTest.java
    cxf/branches/2.1.x-fixes/systests/src/test/resources/crossSchemaBeans.xml

Propchange: cxf/branches/2.1.x-fixes/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Nov  7 13:29:32 2008
@@ -1 +1 @@
-/cxf/trunk:686333-686363,686764,686820,687096,687194,687363,687387,687463,687543,687722,687798,687814,687817,687891,687910,687914,688086,688102,688133,688596,688735,688870,689572,689596,689855,689924,690067,690289,691246,691271,691295,691338,691355,691488,691602,691646,691706,691728,692116,692157,692310,692466,692499,693653,693819,694179,694263,694417,694716,694744,694747,694795,694869,694981,694987,694993,695041,695096,695396,695484,695537,695552,695561,695619,695684,695835,695840,695868,695935,695977,696016,696094,696433,696720,697085,697868,698128,699289,700261,700507,700602,700981,701316,701783,701830,701862,702187,702205-702248,702267,702547,702561,702580,702602,702609,702616,702653,702656,702957,703191,703239,703309,703501,703513,703548,704584,704937,704997,705150,705235,705274,705340,705446,705548,705614,705692,705708,706482,706631,706675,706900,706909,707034,707089,707100,707902,708035,708044,708074,708417,708550,708554,709353-709354,709425,710150,710154,712194,71219
 8
+/cxf/trunk:686333-686363,686764,686820,687096,687194,687363,687387,687463,687543,687722,687798,687814,687817,687891,687910,687914,688086,688102,688133,688596,688735,688870,689572,689596,689855,689924,690067,690289,691246,691271,691295,691338,691355,691488,691602,691646,691706,691728,692116,692157,692310,692466,692499,693653,693819,694179,694263,694417,694716,694744,694747,694795,694869,694981,694987,694993,695041,695096,695396,695484,695537,695552,695561,695619,695684,695835,695840,695868,695935,695977,696016,696094,696433,696720,697085,697868,698128,699289,700261,700507,700602,700981,701316,701783,701830,701862,702187,702205-702248,702267,702547,702561,702580,702602,702609,702616,702653,702656,702957,703191,703239,703309,703501,703513,703548,704584,704937,704997,705150,705235,705274,705340,705446,705548,705614,705692,705708,706482,706631,706675,706900,706909,707034,707089,707100,707902,708035,708044,708074,708417,708550,708554,709353-709354,709425,710150,710154,712194,71219
 8,712272

Propchange: cxf/branches/2.1.x-fixes/
------------------------------------------------------------------------------
Binary property 'svnmerge-integrated' - no diff available.

Modified: cxf/branches/2.1.x-fixes/api/src/main/java/org/apache/cxf/BusFactory.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/api/src/main/java/org/apache/cxf/BusFactory.java?rev=712275&r1=712274&r2=712275&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/api/src/main/java/org/apache/cxf/BusFactory.java (original)
+++ cxf/branches/2.1.x-fixes/api/src/main/java/org/apache/cxf/BusFactory.java Fri Nov  7 13:29:32 2008
@@ -25,7 +25,6 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-import org.apache.cxf.buslifecycle.BusLifeCycleManager;
 import org.apache.cxf.common.classloader.ClassLoaderUtils;
 import org.apache.cxf.common.logging.LogUtils;
 
@@ -173,10 +172,6 @@
     }
 
     protected void initializeBus(Bus bus) {
-        BusLifeCycleManager lifeCycleManager = bus.getExtension(BusLifeCycleManager.class);
-        if (null != lifeCycleManager) {
-            lifeCycleManager.initComplete();
-        }
     }
     
     private static String getBusFactoryClass(ClassLoader classLoader) {

Modified: cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/CXFBusFactory.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/CXFBusFactory.java?rev=712275&r1=712274&r2=712275&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/CXFBusFactory.java (original)
+++ cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/CXFBusFactory.java Fri Nov  7 13:29:32 2008
@@ -25,6 +25,7 @@
 import org.apache.cxf.Bus;
 import org.apache.cxf.BusFactory;
 import org.apache.cxf.bus.extension.ExtensionManagerBus;
+import org.apache.cxf.buslifecycle.BusLifeCycleManager;
 
 public class CXFBusFactory extends BusFactory {
     
@@ -43,4 +44,12 @@
         return bus;
     }
  
+    
+    protected void initializeBus(Bus bus) {
+        super.initializeBus(bus);
+        BusLifeCycleManager lifeCycleManager = bus.getExtension(BusLifeCycleManager.class);
+        if (null != lifeCycleManager) {
+            lifeCycleManager.initComplete();
+        }
+    }
 }

Modified: cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/spring/SpringBusFactory.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/spring/SpringBusFactory.java?rev=712275&r1=712274&r2=712275&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/spring/SpringBusFactory.java (original)
+++ cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/bus/spring/SpringBusFactory.java Fri Nov  7 13:29:32 2008
@@ -25,7 +25,6 @@
 
 import org.apache.cxf.Bus;
 import org.apache.cxf.BusFactory;
-import org.apache.cxf.bus.CXFBusImpl;
 import org.apache.cxf.buslifecycle.BusLifeCycleListener;
 import org.apache.cxf.buslifecycle.BusLifeCycleManager;
 import org.apache.cxf.common.logging.LogUtils;
@@ -139,12 +138,6 @@
             throw new RuntimeException(ex);
         }
     }
-     
-    @Override
-    protected void initializeBus(Bus bus) {        
-        ((CXFBusImpl)bus).initialize(); 
-        super.initializeBus(bus);
-    }
 
     void registerApplicationContextLifeCycleListener(Bus bus, BusApplicationContext bac) {
         BusLifeCycleManager lm = bus.getExtension(BusLifeCycleManager.class);

Modified: cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/buslifecycle/CXFBusLifeCycleManager.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/buslifecycle/CXFBusLifeCycleManager.java?rev=712275&r1=712274&r2=712275&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/buslifecycle/CXFBusLifeCycleManager.java (original)
+++ cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/buslifecycle/CXFBusLifeCycleManager.java Fri Nov  7 13:29:32 2008
@@ -31,6 +31,8 @@
 
     private final List<BusLifeCycleListener> listeners;
     private Bus bus;
+    private boolean preShutdownCalled;
+    private boolean postShutdownCalled;
     
     public CXFBusLifeCycleManager() {
         listeners = new ArrayList<BusLifeCycleListener>();
@@ -66,6 +68,8 @@
     }
     
     public void initComplete() {
+        preShutdownCalled = false;
+        postShutdownCalled = false;
         for (BusLifeCycleListener listener : listeners) {
             listener.initComplete();
         }
@@ -73,15 +77,22 @@
     
     public void preShutdown() {
         // TODO inverse order of registration?
+        preShutdownCalled = true;
         for (BusLifeCycleListener listener : listeners) {
             listener.preShutdown();
         }
     }
     
     public void postShutdown() {
-        // TODO inverse order of registration?
-        for (BusLifeCycleListener listener : listeners) {
-            listener.postShutdown();
+        if (!preShutdownCalled) {
+            preShutdown();
+        }
+        if (!postShutdownCalled) {
+            postShutdownCalled = true;
+            // TODO inverse order of registration?
+            for (BusLifeCycleListener listener : listeners) {
+                listener.postShutdown();
+            }
         }
     }
         

Modified: cxf/branches/2.1.x-fixes/rt/core/src/main/resources/META-INF/cxf/cxf.xml
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/core/src/main/resources/META-INF/cxf/cxf.xml?rev=712275&r1=712274&r2=712275&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/core/src/main/resources/META-INF/cxf/cxf.xml (original)
+++ cxf/branches/2.1.x-fixes/rt/core/src/main/resources/META-INF/cxf/cxf.xml Fri Nov  7 13:29:32 2008
@@ -24,6 +24,7 @@
 http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd">
 
     <bean id="cxf" class="org.apache.cxf.bus.CXFBusImpl"/>
+    <bean id="foo" class="org.apache.cxf.bus.spring.BusApplicationListener"/>
     <bean id="org.apache.cxf.bus.spring.BusWiringBeanFactoryPostProcessor" class="org.apache.cxf.bus.spring.BusWiringBeanFactoryPostProcessor"/>
     <bean id="org.apache.cxf.bus.spring.Jsr250BeanPostProcessor" class="org.apache.cxf.bus.spring.Jsr250BeanPostProcessor"/>    
     <bean id="org.apache.cxf.bus.spring.BusExtensionPostProcessor" class="org.apache.cxf.bus.spring.BusExtensionPostProcessor"/>

Modified: cxf/branches/2.1.x-fixes/rt/core/src/test/java/org/apache/cxf/bus/spring/SpringBusFactoryTest.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/core/src/test/java/org/apache/cxf/bus/spring/SpringBusFactoryTest.java?rev=712275&r1=712274&r2=712275&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/core/src/test/java/org/apache/cxf/bus/spring/SpringBusFactoryTest.java (original)
+++ cxf/branches/2.1.x-fixes/rt/core/src/test/java/org/apache/cxf/bus/spring/SpringBusFactoryTest.java Fri Nov  7 13:29:32 2008
@@ -230,6 +230,9 @@
      
     static class TestFeature extends AbstractFeature {
         boolean initialised;
+        public TestFeature() {
+            //nothing
+        }
 
         @Override
         public void initialize(Bus bus) {

Modified: cxf/branches/2.1.x-fixes/systests/src/test/resources/crossSchemaBeans.xml
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/systests/src/test/resources/crossSchemaBeans.xml?rev=712275&r1=712274&r2=712275&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/systests/src/test/resources/crossSchemaBeans.xml (original)
+++ cxf/branches/2.1.x-fixes/systests/src/test/resources/crossSchemaBeans.xml Fri Nov  7 13:29:32 2008
@@ -34,6 +34,8 @@
 	<import resource="classpath:META-INF/cxf/cxf-extension-local.xml" />
 	<import resource="classpath:META-INF/cxf/cxf-extension-http.xml" />
 
+    <bean class="org.apache.cxf.systest.wsdl.LifeCycleListenerTester" id="listenerTest"/>
+
 	<!-- Services -->
 	<jaxws:server id="JaxbTestServer" 
                    serviceClass="org.apache.type_test.doc.TypeTestPortType"