You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/10/10 00:12:34 UTC

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Hello Mahesh Reddy, Abhishek Chennaka,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/21919

to review the following change.


Change subject: [tests] fix a misprint
......................................................................

[tests] fix a misprint

Tests should use ASSERT_NE(), not DCHECK_NE().

This is a follow-up to e54c80cf9ba129b943eed6af3266899753b1b4ac.

This also fixes compilation on macOS 14.5 for this 1.17.x branch with
Xcode 15.3.

Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Reviewed-on: http://gerrit.cloudera.org:8080/21229
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit ab368443d276006e93370a5b6bd5862eea2475fe)
---
M src/kudu/integration-tests/disk_reservation-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/21919/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21919

to look at the new patch set (#2).

Change subject: [tests] fix a misprint
......................................................................

[tests] fix a misprint

Tests should use ASSERT_NE(), not DCHECK_NE().

This is a follow-up to e54c80cf9ba129b943eed6af3266899753b1b4ac.

P.S.
  This also fixes C++ build on macOS 14.5 for this 1.17.x branch with
  Xcode 15.3.  There was a linker error like below without this patch:

    Undefined symbols for architecture x86_64:
      "void google::MakeCheckOpValueString<std::nullptr_t>(std::__1::basic_ostream<char, std::__1::char_traits<char>>*, std::nullptr_t const&)", referenced from:
	  std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>* google::MakeCheckOpString<std::nullptr_t, kudu::cluster::ExternalTabletServer*>(std::nullptr_t const&, kudu::cluster::ExternalTabletServer* const&, char const*) in disk_reservation-itest.cc.o
    ld: symbol(s) not found for architecture x86_64

Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Reviewed-on: http://gerrit.cloudera.org:8080/21229
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit ab368443d276006e93370a5b6bd5862eea2475fe)
---
M src/kudu/integration-tests/disk_reservation-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/21919/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21919 )

Change subject: [tests] fix a misprint
......................................................................


Patch Set 1:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/586/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2024 00:24:34 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21919 )

Change subject: [tests] fix a misprint
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/587/


-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2024 00:24:39 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21919 )

Change subject: [tests] fix a misprint
......................................................................

[tests] fix a misprint

Tests should use ASSERT_NE(), not DCHECK_NE().

This is a follow-up to e54c80cf9ba129b943eed6af3266899753b1b4ac.

P.S.
  This also fixes C++ build on macOS 14.5 for this 1.17.x branch with
  Xcode 15.3.  There was a linker error like below without this patch:

    Undefined symbols for architecture x86_64:
      "void google::MakeCheckOpValueString<std::nullptr_t>(std::__1::basic_ostream<char, std::__1::char_traits<char>>*, std::nullptr_t const&)", referenced from:
	  std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>* google::MakeCheckOpString<std::nullptr_t, kudu::cluster::ExternalTabletServer*>(std::nullptr_t const&, kudu::cluster::ExternalTabletServer* const&, char const*) in disk_reservation-itest.cc.o
    ld: symbol(s) not found for architecture x86_64

Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Reviewed-on: http://gerrit.cloudera.org:8080/21229
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit ab368443d276006e93370a5b6bd5862eea2475fe)
Reviewed-on: http://gerrit.cloudera.org:8080/21919
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/integration-tests/disk_reservation-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mahesh Reddy: Looks good to me, but someone else must approve
  Abhishek Chennaka: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21919 )

Change subject: [tests] fix a misprint
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/586/


-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2024 00:12:44 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21919 )

Change subject: [tests] fix a misprint
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/587/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2024 02:39:34 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21919 )

Change subject: [tests] fix a misprint
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2024 06:02:18 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.

Change subject: [tests] fix a misprint
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21919 )

Change subject: [tests] fix a misprint
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2024 06:02:32 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tests] fix a misprint

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21919 )

Change subject: [tests] fix a misprint
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I78428cf60449820508f995c4a7c2a84582ce32c1
Gerrit-Change-Number: 21919
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Oct 2024 02:46:14 +0000
Gerrit-HasComments: No